search

numbas / numbas-lti-provider

An LTI tool provider to run Numbas exams
https://docs.numbas.org.uk/lti/en/latest/
Other
11 stars 12 forks source link

If "when to show scores to students" is set to "never", the student's attempts listings page should not show the "review allowed from" date #327

Open christianp opened 2 months ago

christianp commented 2 months ago

There's a missing case in the template for the attempts listing table that the student sees.

If the resource is set to never show scores to students, then they can't re-enter completed attempts in review mode. At the moment, if the "allow students to review attempts from" date is set, then this date is shown in the table, even if it's passed, which is confusing.

I think the template should check attempt.should_show_scores, and only show the date if it's True.