numbats / woylier

Interpolations between bases rather than planes for the tourr package
https://numbats.github.io/woylier/
Other
0 stars 1 forks source link

Week 8 To Do's #6

Closed dicook closed 2 years ago

dicook commented 2 years ago
dicook commented 2 years ago

Oh, tourr::basis_random() produces an othonormal basis, so there is no need to wrap this in tourr::orthonormalise(). So all example code can be simplified

dicook commented 2 years ago

The code for generating the torus is in preprojection_example.R, you can add this into generate_space_view() for when d=2.

dicook commented 2 years ago

Ahhhh,orthonormalisation_by()needed to completely do the orthonormalisation. All is good now when you re-install the tourr package @zolabat

zolabat commented 2 years ago

Oh, tourr::basis_random() produces an othonormal basis, so there is no need to wrap this in tourr::orthonormalise(). So all example code can be simplified

done

zolabat commented 2 years ago

Ahhhh,orthonormalisation_by()needed to completely do the orthonormalisation. All is good now when you re-install the tourr package @zolabat

Thank you. It works perfectly. Now I'm working on 2D.

zolabat commented 2 years ago

Ahhhh,orthonormalisation_by()needed to completely do the orthonormalisation. All is good now when you re-install the tourr package @zolabat

Thank you. It works perfectly. Now I'm working on 2D. Hi Di,

I was wondering if the update in tourr_0.6.1 version? It's the lastest CRAN version but orthonormalise_by() function seems not updated. I could be wrong. @dicook

zolabat commented 2 years ago

It turns out there are 5 different angles and rotation matrices involved in the case of 2D. Completed the tasks above in try_2d.R file.

dicook commented 2 years ago

You need to use the GitHub version of tourr: https://github.com/ggobi/tourr (sorry, just saw this now)