numberly / appnexus-client

:snake: General purpose Python client for the AppNexus API
https://appnexus-client.readthedocs.io
MIT License
39 stars 19 forks source link

Add changelog property on relevant services #29

Closed rambobinator closed 6 years ago

rambobinator commented 6 years ago

Regarding Appnexus documentation: https://wiki.appnexus.com/display/api/Change+Log+Services#ChangeLogServices-getdetails Relevant services are:

I had to rename service parameter to _service since change-log endpoint use it as needed argument.

I also add profile property the same way to keep services creation on a single function instead of redefining class everywhere.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 90.0% when pulling 0cbeba245929a08454181fd2bbc2dc98588f3c7a on feature/changelog into 8d6e389b2c511d598bddc0be7102cc5dddb3a284 on master.

rambobinator commented 6 years ago

@ramnes i made the changes

ramnes commented 6 years ago

@romas, can you please also add an example of usage inside the README? You can also change service to service_name there, on the custom representation code block.

rambobinator commented 6 years ago

@ramnes done

ramnes commented 6 years ago

Thanks!