numberly / appnexus-client

:snake: General purpose Python client for the AppNexus API
https://appnexus-client.readthedocs.io
MIT License
39 stars 19 forks source link

Fix DemographicArea service and add LineItemModel service #30

Closed 1Mmanoncouronne closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.07%) to 86.945% when pulling 54040dee9cba8b1671e2a3ac9473ec61bf1a0dbb on 1Mmanoncouronne:master into d0678b18d10ec7be6f4c9cab34aaba6ef839320e on numberly:master.

ramnes commented 6 years ago

Great! Can you please do the modification in the README file also?

ramnes commented 6 years ago

Also, I think you'll have the same problems with the line-item-model service than with the Genie API services. You might want to make your LineItemModel class inherit from GenieModel (and ideally rename GenieModel for AlphaModel or something in those lines).

ramnes commented 6 years ago

Thank you Manon!