Closed Yay295 closed 7 years ago
There's a similar (but not sufficient) test in test_unpack.py::test_channel_message_commands
that should be expanded/modified to cover TOPIC.
Want me to take care of that, or are you up for it? You've tackled quite a bit lately :)
I think I'd just need to add "TOPIC" to cmd? I don't know where 'nick' comes from in message = command + " nick #ch :m"
though, for any of those commands.
Yep, that should do it. TOPIC has an optional message while the others don't, but that's easy enough to add elsewhere.
How about that? edit: apparently not. seems I'm having bad luck with tests.
ah, that's my bad. I skimmed the definition of topic and missed that channel is always first, followed by optional message.
you can just revert the test change and I'll add that in.
Thanks! 🍰
Codecov Report
96.68% <16.66%> (-3.32%)
98.95% <0%> (+0.01%)
Continue to review full report at Codecov.