numberoverzero / bottom

asyncio-based rfc2812-compliant IRC Client
http://bottom-docs.readthedocs.io
MIT License
74 stars 23 forks source link

add TOPIC parsing #48

Closed Yay295 closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #48 into master will decrease coverage by 1.12%. The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage    99.3%   98.18%   -1.13%     
==========================================
  Files           5        5              
  Lines         434      440       +6     
  Branches      119      121       +2     
==========================================
+ Hits          431      432       +1     
- Misses          2        6       +4     
- Partials        1        2       +1
Impacted Files Coverage Δ
bottom/unpack.py 96.68% <16.66%> (-3.32%) :arrow_down:
bottom/client.py 98.95% <0%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3710e41...0fc366c. Read the comment docs.

numberoverzero commented 7 years ago

There's a similar (but not sufficient) test in test_unpack.py::test_channel_message_commands that should be expanded/modified to cover TOPIC.

Want me to take care of that, or are you up for it? You've tackled quite a bit lately :)

Yay295 commented 7 years ago

I think I'd just need to add "TOPIC" to cmd? I don't know where 'nick' comes from in message = command + " nick #ch :m" though, for any of those commands.

numberoverzero commented 7 years ago

Yep, that should do it. TOPIC has an optional message while the others don't, but that's easy enough to add elsewhere.

Yay295 commented 7 years ago

How about that? edit: apparently not. seems I'm having bad luck with tests.

numberoverzero commented 7 years ago

ah, that's my bad. I skimmed the definition of topic and missed that channel is always first, followed by optional message.

you can just revert the test change and I'll add that in.

numberoverzero commented 7 years ago

Thanks! 🍰