search

numberoverzero / bottom

asyncio-based rfc2812-compliant IRC Client
http://bottom-docs.readthedocs.io
MIT License
76 stars 23 forks source link

Explain RFC deviations in docs #49

Open numberoverzero opened 7 years ago

numberoverzero commented 7 years ago

45 dropped the server1/server2 params of ping/pong since the spec is ambiguous and existing implementations didn't clearly map to one interpretation. That needs to be called out clearly and in an easy to find location. Probably part of any doc rewrite for #43.

Yay295 commented 7 years ago

Does the MODE -> USERMODE change fit under this? What's the reason for that anyway?

numberoverzero commented 7 years ago

It's possible to collapse them into one command, but the arg parsing is non-trivial. I just started refactoring pack.py and had to look those sections up; the command is actually defined in more than one place.

Otherwise there's not much reason for the split; but the arg names don't overlap super well, and just taking a mode string defeats the purpose of abstracting out kwargs anyway.

On Jul 12, 2017 8:51 AM, "Yay295" notifications@github.com wrote:

Does the MODE -> USERMODE change fit under this? What's the reason for that anyway?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/numberoverzero/bottom/issues/49#issuecomment-314812996, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKsgcQE-rRuX2spJMHJOe7Hc-xIR7X9ks5sNOtkgaJpZM4OVKky .