#49 Made browserify create global numbers object.

numbers / numbers.js

Advanced Mathematics Library for Node.js and JavaScript

Apache License 2.0

1.77k stars 167 forks source link

#49 Made browserify create global numbers object. #115

Closed LarryBattle closed 9 years ago

LarryBattle commented 9 years ago

Fixed OP issue from https://github.com/sjkaliski/numbers.js/issues/49

Updated browserify version number to take advantage of the --standalone option.
Ran build process to update number.js and numbers.min.js

LarryBattle commented 9 years ago

Source for Travic CI browserify fix https://github.com/npm/npm/issues/5823

LarryBattle commented 9 years ago

@StDako Yo. Can you click the rebuild button in Travic CI? Guide: http://stackoverflow.com/questions/17606874/trigger-a-travis-ci-rebuild-without-pushing-a-commit

Dakkers commented 9 years ago

@LarryBattle will do some time soon. if you can remember to ping me on Monday, I'll do it then. I may remember on my own

Dakkers commented 9 years ago

@LarryBattle restarted the build. I'll be looking into fixing #116 hopefully sometime this week. I've been awfully busy with a bunch of shit but yeah. as soon as this build is done I'll merge the PR

Dakkers commented 9 years ago

@LarryBattle you're gonna have to resubmit this, but I have to update the travis.yml file first because we're using gulp now.

LarryBattle commented 9 years ago

@StDako No need to resubmit. The pull request that was merged contains the fix. https://github.com/sjkaliski/numbers.js/pull/118 Basically, all that was needed is to pass {standalone: "numbers"} to browserify. https://github.com/sjkaliski/numbers.js/blob/master/gulpfile.js#L24

However, please rebuild number.js to fix this issue. npm run build