#124 fix gulp format error

numbers / numbers.js

Advanced Mathematics Library for Node.js and JavaScript

Apache License 2.0

1.77k stars 167 forks source link

#124 fix gulp format error #127

Closed Dakkers closed 9 years ago

Dakkers commented 9 years ago

fix #124 since gulp-jsbeautifier was updated (incompatibility; see https://github.com/tarunc/gulp-jsbeautifier/pull/2

Dakkers commented 9 years ago

cc @LarryBattle . merging this as soon as the Travis CI build is done

LarryBattle commented 9 years ago

:-) Looks good. But I was thinking about getting rid of gulp-jsbeautifer and just using the js-beautifer module directly in gulp. gulp-jsbeautifer makes it a little bit harder passing the correct options to js-beautifer.

Dakkers commented 9 years ago

sweet. if you want to submit a PR for that, I'll just close this and rollback. I don't mind either way.

LarryBattle commented 9 years ago

Right now, I think it would be best if you merge this change and get rid of the note for formatting in readme.md. I'll open up another pull request if switching to a new formatting module would be beneficial to the project.