Closed Dakkers closed 9 years ago
LGTM
@LarryBattle :
I've noticed that we're kind of hacky with the square matrix checking. most functions we have don't actually use matrix.isSquare(M)
to check if it's a matrix, we just check the first row and hope that the user didn't enter it incorrectly. we should be checking properly. I'll fix this today. a lot of functions also throw the exact same errors, so we could have a private function throw an error if needed.
as for the private method for the for-loops, that's reasonable too. I'll throw that in today as well.
sorry for jumping the gun!
there's also a lot of inconsistency with the way errors are thrown. I'll be fixing that too.
yep:
isRowDD
,isColumnDD
,isStrictlyRowDD
,isStrictlyColumnDD
; these functions are useful for numerical stability-related junk.matrix.zeros
better (realized I originally useArray.push()
instead of allocating the right amount of memory usingnew Array(n)
cc @LarryBattle