search

numbers / numbers.js

Advanced Mathematics Library for Node.js and JavaScript
Apache License 2.0
1.77k stars 167 forks source link

formatted errors, factored code #129

Closed Dakkers closed 9 years ago

Dakkers commented 9 years ago

additions to #128 . I probably forgot to update the src/ at the very end, shit.

Dakkers commented 9 years ago

cc @LarryBattle

LarryBattle commented 9 years ago

Looks good. Private methods, like matrix._sumNondiagonalElements(), don't really have need to be exposed. So I would just declare them inside the module without attaching them to the export object.

Dakkers commented 9 years ago

right right, will update the exports.

most of the code thus far is written like that. I agree it is weird but I would rather be consistent (as it stands now) and kinda weird than have to rewrite all of the error-throwing blocks. although maybe we could just use jsfmt, if it supports that kind of thing.

Dakkers commented 9 years ago

@LarryBattle I'm going to merge this for now because I want to get the linalg functions started. we can come back to this later if need be.

LarryBattle commented 9 years ago

Sounds good. I'll try to help out if I have sometime.