search

numbers / numbers.js

Advanced Mathematics Library for Node.js and JavaScript
Apache License 2.0
1.77k stars 167 forks source link

Adding permutation calculations. #131

Closed devanp92 closed 9 years ago

devanp92 commented 9 years ago

Added permutation method in basic.js as well as tests for permutation in basic.tests.js

Dakkers commented 9 years ago

apologies for getting to this so late -- looks good.

devanp92 commented 9 years ago

No worries. What is the state of the project? I wanted to contribute more, however, the project looks inactive.

Dakkers commented 9 years ago

it kind of is inactive. if you're looking for small things to do in the mean time, there are several functions that don't throw errors where they should. you can find these in the documentation at http://www.numbersjs.info/

just scroll through the modules and look for functions that have "This function does not throw any errors, but it should". the errors should probably be obvious (e.g. throwing a negative integer into the factorial function)

devanp92 commented 9 years ago

Ok. I created a PR in the docs repo for the permutation. I will check out the functions without errors.