search

numbers / numbers.js

Advanced Mathematics Library for Node.js and JavaScript
Apache License 2.0
1.76k stars 168 forks source link

change lib to src #68

Closed milroc closed 11 years ago

milroc commented 11 years ago

It just makes the library more approachable for new developers (it's a standard on popular github .js libraries) and future proof's the library, in case for whatever reason we need to have dependencies we can have a lib file for that. I'd make a pull request to fix this if you want but figured I'd get other's input on it.

KartikTalwar commented 11 years ago

I agree with Miles here. It does appear to be a standard in most js libraries and projects.

sjkaliski commented 11 years ago

https://github.com/visionmedia/express and https://github.com/LearnBoost/socket.io

Both use lib. It's pretty standard across node.js libraries. We can change public to src...since that's the 'JavaScript' portion of the library. Thoughts?

milroc commented 11 years ago

It might just be my personal bias, I guess both are fine, perhaps this is better since it has more use cases with Node than within the browser (which we are still intending to continue with right?).

sjkaliski commented 11 years ago

It has equivalent use cases. @zikes made some cool stuff with numbers.js and d3.js. We should be building flexible tools that work both ways.

milroc commented 11 years ago

Agreed. I'm closing this because currently this issue is less of one than I was thinking.