Improved square matrix detection

numbers / numbers.js

Advanced Mathematics Library for Node.js and JavaScript

Apache License 2.0

1.76k stars 168 forks source link

Improved square matrix detection #88

Closed jdan closed 11 years ago

jdan commented 11 years ago

The original implementation only checked the length of the first row. You may want to consider stronger assertions in your matrix methods in general.

jdan commented 11 years ago

Hey @sjkaliski what's your preferred workflow? Do you prefer branches on separate forks?

sjkaliski commented 11 years ago

@prezjordan I added you as a collaborator on the repo, so you can just make your own forks, set up a PR, we'll review it an merge it in. For anyone else collaborating (but not as a official collaborator), fork -> PR -> review -> merge is the flow.

jdan commented 11 years ago

Sounds good, wasn't sure :) Thanks