search

numberscope / frontscope

Numberscope's front end and user interface: responsible for specifying sequences and defining and displaying visualizers
MIT License
7 stars 14 forks source link

Specimen browser storage #355

Closed kaldis-berzins closed 1 week ago

kaldis-berzins commented 1 week ago

By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.

This PR is second in the PR merge chain.

Specimen browser storage

This PR adds two new files that aren't used anywhere at this point: browserCaching.spec.ts and browserCaching.ts. browserCaching.ts adds the interface for storing specimens in the browser. This file is updated in later iterations, but largely remains the same.

gwhitney commented 1 week ago

This is very confusing. The "files changed" tab on this PR is showing 25 files changed , whereas if I check out specimens_browser_storage in my local clone and do git diff --stat ui2 it shows only 8 files changed, and if I am reading the PR description correctly, all that this should be doing is adding two files. Can anyone clarify the situation? I think that certainly some of the issue is the conflicts that need to be resolved. If anyone is able to resolve those conflicts, that would be great; that might clear up the weirdness with the "files changed tab". When we get this weirdness ironed out, then we can return to the main review. If anyone from the Delft team can simply confirm that all this PR should be doing is adding two files (namely src/shared/browserCaching.ts and src/shared/tests/browserCaching.spec.ts), then I think the simplest thing to do would be to create a new fresh single-commit PR that just adds those two files to the current state of ui2. Anyone who would be able to do that, please do. Thanks to all reading this for your help!

gwhitney commented 1 week ago

OK, having slept on it, my plan is to just look at the diffs between the final files in this PR, sift out any changes that are from conflicting changes previously made, and create a new fresh PR with just the remaining changes on top of ui2. When that PR is in place, I will close this one unmerged.

gwhitney commented 1 week ago

Closing in favor of #362.