Closed kaldis-berzins closed 6 days ago
Starting to create a cleaned version of this to lie atop #366
Why does this PR rename saveSpecimen
to saveSpecimenToBrowser
? There doesn't seem to be any other sort of saving of a specimen, and so in the absence of any ambiguity, I don't see the motivation to rename. Unless someone weighs in with a justification, in the cleaned version I will leave the function called just saveSpecimen to reduce the number of changes.
Why does this PR rename
saveSpecimen
tosaveSpecimenToBrowser
?
I determined that it was because SpecimenBar had an internal function "saveSpecimen" and so the renaming was to avoid a name clash in that component. But since that was a purely internal function, I just renamed the internal one to "saveCurrent", so that the cleaned PR would touch fewer files. Closing this in favor of #367.
By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.
This branch is fourth in the PR merge chain.
Specimen bar
Navbar
App.vue
. The navbar now has to be added to each view separately because it may be different for differrent views.Specimen bar
sequence_visualizer_switcher
PR, so doing a thorough review may not be necessary, but the bar should work at this point.Visualizers