By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.
This is merge number 8 in the PR merge chain.
End-to-end testing
Testing framework
Playwright is now being used for end-to-end tests.
The end-to-end tests run using Firefox and Chromium.
New tests
New tests are in the e2e folder.
The tests often depend on specific classes and IDs, so they may need to be updated upon changes to Numberscope.
The tests can be executed as the following npm script: npm run test:e2e
An interactive testing UI and debugger can be executed as the following npm script: npm run test:e2e:ui
NOTE: This PR is completely optional, as it wasn't explicitly requested by you, and contains no features pertaining to the requirements. One reason you may not want to merge it is that Playwright is a rather large dependency, as it installs several headless browsers. It would also be rather heavy to include these tests in the commit hooks (note that this PR does not add them to the commit hooks). Nevertheless, it is a relatively extensive suite of end-to-end tests for the new version of Numberscope per what we agreed, and if you wish to incorporate it, all necessary components are contained within this PR.
By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.
This is merge number 8 in the PR merge chain.
End-to-end testing
Testing framework
New tests
e2e
folder.npm run test:e2e
npm run test:e2e:ui
NOTE: This PR is completely optional, as it wasn't explicitly requested by you, and contains no features pertaining to the requirements. One reason you may not want to merge it is that Playwright is a rather large dependency, as it installs several headless browsers. It would also be rather heavy to include these tests in the commit hooks (note that this PR does not add them to the commit hooks). Nevertheless, it is a relatively extensive suite of end-to-end tests for the new version of Numberscope per what we agreed, and if you wish to incorporate it, all necessary components are contained within this PR.