search

numberscope / frontscope

Numberscope's front end and user interface: responsible for specifying sequences and defining and displaying visualizers
MIT License
7 stars 15 forks source link

Resizing and url integration [cleaned] #366

Closed gwhitney closed 4 months ago

gwhitney commented 4 months ago

By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.

  Changes to tabs
    * Added buttons that let you control the tabs without dragging
    * Support minimizing of tabs.
    * Added a highlight to the tab that is currently selected.
    * Initial mobile compatibility in the style section of Tab.vue

  Resizing
    * Added a reset function to a specimen. This is a hard reset that is used
      when the specimen is resized and it doesn't override resized function.
    * Added a resized function to both specimens and visualizers. It is not
      required for visualizers as they can just not do anything and the
      specimen will hard reset them.

  Scope
    * Adds rudimentary mobile support.

Supersedes #356.

gwhitney commented 4 months ago

I will review when next I can work on this but @katestange and/or @Vectornaut feel free to jump in in the meantime if you happen to have a chance.

gwhitney commented 4 months ago

Aside from the comments mentioned, it seems very robust on desktop view. The behaviour is pretty intuitive.

Did you get a chance to try it with a variety of visualizers (by changing "ModFill" in Scope.vue to the names of other visualizers)?

katestange commented 4 months ago

Did you get a chance to try it with a variety of visualizers (by changing "ModFill" in Scope.vue to the names of other visualizers)?

Yes, although not every single one. I'll try a couple more.

katestange commented 4 months ago

Works great, merging.