search

numberscope / frontscope

Numberscope's front end and user interface: responsible for specifying sequences and defining and displaying visualizers
MIT License
7 stars 15 forks source link

Fix dropzone [ui2] #377

Closed gwhitney closed 4 months ago

gwhitney commented 4 months ago

By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.

Fixes the reversion in #368: as a tab is dragged, the left dropzones again highlight as the tab enters the region in which the tab will dock into the zone.

Resolves #376.

katestange commented 4 months ago

This appears to work perfectly when opening scope and moving the tabs around. But when I got to gallery and pick a new featured visualizer, it begins misbehaving, showing both right and left dropzones simultaneously etc.

Screenshot from 2024-07-04 17-01-22

gwhitney commented 4 months ago

I see the bad-looking screenshot, but cannot reproduce it here. Can you give an exact sequence of steps, say starting from a fresh Numberscope window showing the Basic Modfill visualizer (http://localhost:5173/?specimen=eyJuYW1lIjoiQmFzaWMgTW9kZmlsbCIsInNlcXVlbmNlIjoiUmFuZG9tIiwic2VxdWVuY2VQYXJhbXMiOiJleUp0YVc0aU9pSXlJaXdpYldGNElqb2lNVFFpZlE9PSIsInZpc3VhbGl6ZXIiOiJNb2RGaWxsIiwidmlzdWFsaXplclBhcmFtcyI6ImV5SnRiMlJFYVcxbGJuTnBiMjRpT2lJeE1pSjkifQ==), to produce the bad behavior shown? Thanks so much.

katestange commented 4 months ago

I see the bad-looking screenshot, but cannot reproduce it here. Can you give an exact sequence of steps, say starting from a fresh Numberscope window showing the Basic Modfill visualizer (http://localhost:5173/?specimen=eyJuYW1lIjoiQmFzaWMgTW9kZmlsbCIsInNlcXVlbmNlIjoiUmFuZG9tIiwic2VxdWVuY2VQYXJhbXMiOiJleUp0YVc0aU9pSXlJaXdpYldGNElqb2lNVFFpZlE9PSIsInZpc3VhbGl6ZXIiOiJNb2RGaWxsIiwidmlzdWFsaXplclBhcmFtcyI6ImV5SnRiMlJFYVcxbGJuTnBiMjRpT2lJeE1pSjkifQ==), to produce the bad behavior shown? Thanks so much.

Open link above. Move both tabs (sequence and visualizer) to dock left. Click Gallery. Choose Latticework. Should produce this screenshot.

gwhitney commented 4 months ago

Hmm. I probably won't get back to it today, but if you see this in the meantime let me know what browser, and make certain you are fully in sync with this pr, npm installed, and hard reloaded with a fresh instance of npm run dev. Or if you don't get to it either, I will try with various browsers when I can.

katestange commented 4 months ago

Hmm. I probably won't get back to it today, but if you see this in the meantime let me know what browser, and make certain you are fully in sync with this pr, npm installed, and hard reloaded with a fresh instance of npm run dev. Or if you don't get to it either, I will try with various browsers when I can.

Yes, I just did a pull, install, hard reload. It happens for me in Chromium and Microsoft Edge and Firefox. I even cleared browser cache.

gwhitney commented 4 months ago

OK, have reproduced. Will address as soon as I have a chance.

gwhitney commented 4 months ago

All right, this exact problem is addressed (and apparently solved) by specific code in the next PR from the Delft team. Therefore, I am merging this PR and submitting the cleaned version of the next one for us to start beating on (and critiquing/improving, as I think it will need).