numberscope / frontscope

Numberscope's front end and user interface: responsible for specifying sequences and defining and displaying visualizers
MIT License
7 stars 15 forks source link

Sequence and visualizer switcher [cleaned] #379

Closed gwhitney closed 1 month ago

gwhitney commented 2 months ago

By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.


Switchers

Parameter Editor

Specimen bar

Mobile

Scope

katestange commented 1 month ago

Great! I think leaving mobile for later is a reasonable call. This PR is big and well-defined enough without it. I noticed that in workbench mode trying to change the visualizer results in a pop-up error. How do I test properly in production?

gwhitney commented 1 month ago

I am 75% sure that is because the Grid visualizer is dead, and has been put in workbench (sort of hard to debug because of the way that our error popup blocks the javascript debugger). As far as I can see, you can just click "Ok" and everything will keep working except you can't use the Grid visualizer, and you can beat on everything else to your heart's content.

katestange commented 1 month ago

Ok, I've been beating on this for a long time, so I'm satisfied. Would you like @Vectornaut to weigh in or would you like me to go ahead and squash/merge?

gwhitney commented 1 month ago

I am personally comfortable with your squash-merging it to ui2.