numbersprotocol / capture-lite

A photo-sharing app with only verifiable photos and videos.
https://numbersprotocol.github.io/
GNU General Public License v3.0
25 stars 6 forks source link

[FR] improve the delete account button #1943

Closed sync-by-unito[bot] closed 2 years ago

sync-by-unito[bot] commented 2 years ago

User story: As a Capture App user, I want improve the delete account button so that I can consider more detail about deleting account.

Feature request:

  1. fade the delete button
  2. Let more information about the delete account risk.

    ( ex: Account escrow wallet will no longer be available Unable to recover deleted account content )

Feature request:

  1. Menu → profile → Delete my account

┆Issue is synchronized with this Asana task by Unito ┆Created By: Kenny Hung

sync-by-unito[bot] commented 2 years ago

➤ Kenny Hung commented:

Information: It will include

  1. Your NUM token in asset wallet will disappear.
  2. Your asset which haven't minted NFT will disappear.
sync-by-unito[bot] commented 2 years ago

➤ Kenny Hung commented:

need noir suggestion

sync-by-unito[bot] commented 2 years ago

➤ Tammy Yang commented:

We will use archive.

Basic flow:

  1. User click menu of their own Capture (at the top-right corner)
  2. User choose “archive” from the menu
  3. A popup shows the archived item will still be on chain but will not appear in the Numbers Network
  4. If yes, calls backend API to delete the asset
sync-by-unito[bot] commented 2 years ago

➤ Kenny Hung commented:

Tammy Yang Wait! As I know this feature is about delete "account" instead of delete asset, we will use archive should be this card. ([FR] Allow users to remove assets from Capture App ( https://app.asana.com/0/1201016280880500/1202798342707582/f ))

sync-by-unito[bot] commented 2 years ago

➤ Kenny Hung commented:

about delete account should follow the figma design.

sync-by-unito[bot] commented 2 years ago

➤ Sam commented:

Kenny Hung, when user clicks "Close account" which text I should put as a warning? I look on internet and found similar text. Example screenshot 1 ( https://help.textplus.com/galleryDocuments/edbsn8cdd354b5a9510e148bf6d0726620d2c5cfb476c72314723eada8762cc01e4fe64cd4d9b8f95f602c0d932a070e1bc39?inline=true ), 2 ( https://uploads-ssl.webflow.com/5d7142044df04fda1a7795b9/5f2012142cf37c285e03efc6_chrome_24h4W2jOrk.png ), and 3 ( https://support.appintheair.com/hc/article_attachments/360084353373/tvFvBtyorwCqE672IHYanhfQ4Ek3OkQ5NQ.png )

Current text in capture 0.68.0 is Your local data will be wiped out after deletion. Please double-check that you have created a backup and understand the risk.

As a new text for close account warning dialog I propose this text. Close account. Are you sure? Your NUM token in asset wallet will disappear. Your assets which haven't minted NFT will disappear. You will no longer have access to your account. This is irreversible.

Please let me know if new text is okay (cc: Tammy Yang)

sync-by-unito[bot] commented 2 years ago

➤ Sam commented:

Kenny Hung, here is the claap ( https://app.claap.io/numbers-protocol/qa-close-account-text-confirmation-c-O35CsUM4Uy-4ZTJm8PIpx6T ) of how it looks now. Still waiting for text confirmation and translation.

sync-by-unito[bot] commented 2 years ago

➤ Kenny Hung commented:

Tammy Yang ^ ^ please help to confirm the text about delete button warning.

sync-by-unito[bot] commented 2 years ago

➤ Sam commented:

Tammy Yang, here is the shareable doc ( https://docs.google.com/document/d/1cdgSetr6zgOjP5MbLEhI7klFT7QcU8RqYnu89WO-Wh8/edit?usp=sharing ).

sync-by-unito[bot] commented 2 years ago

➤ Sam commented:

Kenny Hung, this task should removed from v221101.

Implementations is done (coding part) but for text confirmation we still need to wait noir's answer ( https://dt42-numbers.slack.com/archives/C03NMG0KQ67/p1667281944237389?thread_ts=1667280565.008429&cid=C03NMG0KQ67 ).

sync-by-unito[bot] commented 2 years ago

➤ Kenny Hung commented:

Sam so in today's release, QA could see this feature? If yes, I think it should still add this into v221101 release, if anything text needs to adjust, we could do it in the future.

sync-by-unito[bot] commented 2 years ago

➤ Sam commented:

Kenny Hung, okay I will add code for today's release and will change text for next release.

So en-us text will be: Your NUM token in asset wallet will disappear. Your assets which haven't minted NFT will disappear. You will no longer have access to your account. This is irreversible.

Kenny Hung, can you please help with zh-tw translation?

Also how can we say "close account" in chinese?

sync-by-unito[bot] commented 2 years ago

➤ Sam commented:

Here is the PR ( https://github.com/numbersprotocol/capture-lite/pull/2260 )

sync-by-unito[bot] commented 2 years ago

➤ Kenny Hung commented:

Tammy YangSam Because the text includes the zh-tw content, this content needs Sofia Yan 's help, do we postpone this feature to next sprint?

sync-by-unito[bot] commented 2 years ago

➤ Tammy Yang commented:

What if we don't have zh-tw translation?

sync-by-unito[bot] commented 2 years ago

➤ Sam commented:

Kenny Hung (cc: Tammy Yang) we still can deliver in this sprint.

Next sprint we will just need to change text.

Currently I use same text that was before.

Here is the claap ( https://app.claap.io/numbers-protocol/dev-delete-account-button-moved-to-settings-page-c-O35CsUM4Uy-3gVcj4WYr8pD ).

sync-by-unito[bot] commented 2 years ago

➤ Kenny Hung commented:

Tammy Yang for new version text, I don't receive the zh-tw translation.

sync-by-unito[bot] commented 2 years ago

➤ Sam commented:

Kenny Hung, yes for this sprint we use old text.

Your local data will be wiped out after deletion. Please double-check that you have created a backup and understand the risk. 所有您的本地資料將會在刪除帳號後清除。請再次確認您已備份資料並了解其中的風險。

sync-by-unito[bot] commented 2 years ago

➤ Kenny Hung commented:

Sam Just confirm the delete account button, does it work real? or just the fake button still need Scott to use api delete account?

sync-by-unito[bot] commented 2 years ago

➤ Sam commented:

Kenny Hung It’s not fake it has functionality

sync-by-unito[bot] commented 2 years ago

➤ Kenny Hung commented:

Sam QA tried it and found it's the same as before, just a fake button still need Scott to use api delete account. (I'll add new FR card for it and arrange in the future.)

sync-by-unito[bot] commented 2 years ago

➤ Tammy Yang commented:

Kenny HungSamI think it will be nice if we fix it before pushing the App to App Store/Google Play. Maybe we can schedule an additional release next Tuesday only for this?

sync-by-unito[bot] commented 2 years ago

➤ Sam commented:

Sure Kenny Hung, I can fix it tomorrow so it can be added for Tuesday release 😇

sync-by-unito[bot] commented 2 years ago

➤ Kenny Hung commented:

I think it's okay, I'll arrange it on sprint 1107 sprint.