Fit figma - Edit profile page

[sync-by-unito[bot]]

compare figma design & current capture app: https://docs.google.com/presentation/d/1u6-l_xDVBcPc708B3TR13DBKAoySjfKu7Hp-PGkfni0/edit#slide=id.g1746b1795ba_0_72

On sprint 1219, we will do these

1. Click profile => can update profile
2. Click user name => can update user name

Expectation Add a new page could let user edit their profile information

1. User name
2. Profile photo
3. description
4. Profile img (background img)

And this UI display should sync on creator page.

3, #4 will finish on [FR] Add edit feature for user description & background img on profile page

User story As a capture app user, I want an edit profile page, so that I can edit my information easily.

┆Issue is synchronized with this Asana task by Unito ┆Created By: Kenny Hung

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, I saw the google slide ( https://docs.google.com/presentation/d/1u6-l_xDVBcPc708B3TR13DBKAoySjfKu7Hp-PGkfni0/edit#slide=id.g1746b1795ba_0_25 ) that for activity and inbox we need more discussion ( https://i.imgur.com/XFLzV9d.png ). Is there any update on what to do with the inbox and activity?

[sync-by-unito[bot]]

➤ Tammy Yang commented:

Good reminder.

Let's do this (DO NOT follow Figma):

1. Click profile => can update profile
2. Click user name => can update user name
3. Click email => can update email

Let me know if this makes sense.

[sync-by-unito[bot]]

➤ Sam commented:

Tammy Yang, we want to do

1. Click profile => can update profile
2. Click user name => can update user name
3. Click email => can update email

Because it's a smaller scope?

I think we can still follow figma it's not huge changes in UI code there will be some but not huge.

https://app.claap.io/numbers-protocol/c-O35CsUM4Uy-7FOVEuldS84h ( https://app.claap.io/numbers-protocol/c-O35CsUM4Uy-7FOVEuldS84h )

[sync-by-unito[bot]]

➤ Sam commented:

Tammy Yang also regarding "Remove upload status bar"

https://app.claap.io/numbers-protocol/tammy-do-we-hide-upload-progres-conditionally-c-O35CsUM4Uy-AqdY0zf59VF7 ( https://app.claap.io/numbers-protocol/tammy-do-we-hide-upload-progres-conditionally-c-O35CsUM4Uy-AqdY0zf59VF7 )

[sync-by-unito[bot]]

➤ Tammy Yang commented:

No, please keep the current implementation because there is no better place for activity and inbox.

[sync-by-unito[bot]]

➤ Tammy Yang commented:

For upload status bar, please KEEP it as it is and do NOT make any changes. This is super important because it is not just a progress bar but with the super important feature to pause the upload.

[sync-by-unito[bot]]

➤ Sam commented:

Tammy Yang, Okay then lets do as you mentioned before. Here is the summary of what i'm gonna do to mark this task as completed. Please confirm if so.

https://app.claap.io/numbers-protocol/tammy-regarding-fit-figma-edit-profile-page-task-c-O35CsUM4Uy-gGuQwLKn8jUn ( https://app.claap.io/numbers-protocol/tammy-regarding-fit-figma-edit-profile-page-task-c-O35CsUM4Uy-gGuQwLKn8jUn )

[sync-by-unito[bot]]

➤ Tammy Yang commented:

Sam

For profile pic: I think it already exists (at least my version supports it), so no need to update For user name and email => yes.

[sync-by-unito[bot]]

➤ Sam commented:

Tammy Yang, yes profile pic already support update. My question was should it be bigger or same size.

[sync-by-unito[bot]]

➤ Sam commented:

I finished minimal requirements Kenny Hung please have a look at this claap https://app.claap.io/numbers-protocol/kenny-simple-version-of-fit-figma-edit-profile-page-c-O35CsUM4Uy-eWNTgOJESgWd ( https://app.claap.io/numbers-protocol/kenny-simple-version-of-fit-figma-edit-profile-page-c-O35CsUM4Uy-eWNTgOJESgWd )

Let me know if QA thinks it's acceptable. If yes I will create PR.

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Tammy Yang Just want to confirm a few part. The profile img should be bigger or the same size?

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam It looks nice! Just remind, you need to notice the error handling of changing user name & email (when the user name/email is duplicate.)

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, okay I will test that case as well thank you for reminding 🙏

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, you were right I tried a duplicate email, and username and it might need some fixes from the backend first.

Olga, can you please check if the update user ( https://app.claap.io/numbers-protocol/dia-api-v3-update-current-user-check-for-duplicate-username-email-c-O35CsUM4Uy-5mmwkqnMi7Na ) endpoint is checking for duplicate emails, and usernames?

I explained here more in claap https://app.claap.io/numbers-protocol/dia-api-v3-update-current-user-check-for-duplicate-username-email-c-O35CsUM4Uy-5mmwkqnMi7Na ( https://app.claap.io/numbers-protocol/dia-api-v3-update-current-user-check-for-duplicate-username-email-c-O35CsUM4Uy-5mmwkqnMi7Na )

[sync-by-unito[bot]]

➤ Olga commented:

Sam duplicate username is an issue [Issue] Fix status 500 when update a duplicate username ( https://app.asana.com/0/1201016280880508/1203397449817430/f ) and have to be fixed in the future sprint. But email is not unique in storage backend DB, do we want to add this limitation?

[sync-by-unito[bot]]

➤ Sam commented:

Olga, thank you for the clarification.

Regarding duplicate emails, I think we should prevent duplicate emails as well. Because I had two emails sultanmyrza@gmail.com ( mailto:sultanmyrza@gmail.com ) & sultanmyrza@icloud.com ( mailto:sultanmyrza@icloud.com ).

When I was demoing in the claap I renamed sultanmyrza@gmail.com ( mailto:sultanmyrza@gmail.com ) to sultanmyrza@icloud.com ( mailto:sultanmyrza@icloud.com ) I think it should be prevented.

Because now I can not log in with sultanmyrza@gmail.com ( mailto:sultanmyrza@gmail.com ) after changing sultanmyrza@gmail.com ( mailto:sultanmyrza@gmail.com ) to sultanmyrza@icloud.com ( mailto:sultanmyrza@icloud.com ). So I believe we should prevent updating email if that email already exists.

But we still need confirmation from Tammy Yang.

[sync-by-unito[bot]]

➤ Tammy Yang commented:

Olga email is not unique because we allow users to attach multiple emails to one wallet (wallet is the unique key of user, not email)

For my understanding of the backend, users can use both emails to login after adding them to the backend.

If that's the case, I don't think there is a need to change anything in the backend.

[sync-by-unito[bot]]

➤ Tammy Yang commented:

Sam please drop the email update.

The conversation reminds me one thing that we don't have UX to handle what if user input the wrong email. In that case, if they logout by incident, they won't be able to login again (because the email was wrong).

[sync-by-unito[bot]]

➤ Tammy Yang commented:

I think we can leave it until we have the proper DID solution. At the mean time, I believe we don't want to add more changes to the centralized user system (cc Bofu Chen )

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Updated description

[sync-by-unito[bot]]

➤ Kenny Hung commented:

cc Natalie Wang

3, #4 will add into 0102 sprint