[Duplicate] Upgrade android API level

[sync-by-unito[bot]]

To pass the android play store review we need to upgrade the Android API level to 31. According to the ionic official guide, It might need several steps.

1. update android api
2. upgrade to ionic 4 (not sure yet)
3. upgrade camera plugin dependencies

┆Issue is synchronized with this Asana task by Unito ┆Created By: Sam

[sync-by-unito[bot]]

➤ Sam commented:

Bofu Chen, here is the PR ( https://github.com/numbersprotocol/capture-lite/pull/2325 ).

PR includes upgrading the android API level with minimal changes to pass the Google Play Store review. Once we pass the Play Store review I would recommend following the official ionic guide "Updating from Capacitor 3 to Capacitor 4" ( https://capacitorjs.com/docs/apis/geolocation ).

[sync-by-unito[bot]]

➤ Sam commented:

"Updating from Capacitor 3 to Capacitor 4" ( https://capacitorjs.com/docs/apis/geolocation ) is good because

• Update the iOS version to 13.0:

• Update the Android API level to 31

  • Gradle to 7
  • java to 11 (capacitor 4 works with java 11 and higher)

• Update @capacitor/xxx dependencies

For example current version "@capacitor/geolocation": "^1.3.1", is too old (last published 10 months ago). To update @capacitor/geolocation we need to first update @capacitor/core from 3 to 4 which will start cascade updates (typical migration process)

[sync-by-unito[bot]]

➤ Sam commented:

updating the @capcitor/geolocation plugin might potentially solve the location issue. QA mentioned that on android 12 (API 31) there is an error when uploading the capture so using the latest location plugin might help.

[sync-by-unito[bot]]

➤ Sam commented:

created separate a card ( https://app.asana.com/0/1201016280880500/1203398058668097/f ) for "Updating from Capacitor 3 to Capacitor 4" ( https://capacitorjs.com/docs/apis/geolocation )

[sync-by-unito[bot]]

➤ Sam commented:

By the way, I tested the android camera, and location feats. On android Galaxy M12 (android 12)

• camera ✅
• location ✅

On android Pixel 6a (android 12)

• camera ✅
• location ☢️, when first time capture location can't be obtained subsequent capture locations can be obtained.

[sync-by-unito[bot]]

➤ Bofu Chen commented:

Sam Thanks for sharing the testing results 👍

Tammy, Sherry, and I also encounter this geolocation issue, and we guess that this issue is affecting many Android users. If you fix the geolocation on Pixel 6, we are happy to test together on our phones.

[sync-by-unito[bot]]

➤ Sam commented:

Bofu Chen, yes currently working on it. Will update status once I get a progress.

[sync-by-unito[bot]]

➤ Sherry Chung commented:

Sam Maybe that's the root cause of this issue? [issue] Capture app doesn't allow Pixel6A user to confirm to register photos. ( https://app.asana.com/0/0/1203175716103883 )

[sync-by-unito[bot]]

➤ Sam commented:

Sherry Chung not sure yet. But working on it

[sync-by-unito[bot]]

➤ Sam commented:

Dev status update:

I migrated from capacitor 3 to capacitor 4.

During migration, I upgraded our "@capacitor/geolocation" from 1.1.0 to 4.00. And as you can see when there is no issue with getting the location at first capture (fresh install) Before the first capture could not get location (when fresh install the app).

Because @capacitor/gelocation is developed by ionic team they might added some changes on native side so it works properly on android 12. But it's just an assumption after release QA can confirm if it fixed the issue or not.

Next, I will clean up migration commits and send PR. After the migration issue is completed I will work on issues on pixel 6a capture/camera related.

[sync-by-unito[bot]]

➤ Sherry Chung commented:

But it's just an assumption after release QA can confirm if it fixed the issue or not. Sam Please let QA know how to test this task. Also, since we only have 1 Pixel 6 on our hand. If pixel 6 is the only way to do the test, you need to connect with Kenny to deliver the phone (or you can meet in person next week).

If it had been publish to Google Play console, I can ask if my friend can help to test this Sat.

cc Kenny Hung

[sync-by-unito[bot]]

➤ Sherry Chung commented:

Sam because we only have 1 pixel 6 phone, not sure if QA can successfully check this task. You might need to meet Kenny in person or arrange the phone delivery.

Kenny Hung Can you check the android version of pixel5? If it's not android 12, can it be upgraded to android 12?

[sync-by-unito[bot]]

➤ Sam commented:

Sherry Chung sure first I will fix migration issues and camera issues (because I need pixel 6 during development debugging)

Once I finish I will send to Kenny Hung so he will be able to test during release

[sync-by-unito[bot]]

➤ Sherry Chung commented:

I’ve tried with my friend’s pixel 6A. The location problem still occurred.

[sync-by-unito[bot]]

➤ Sam commented:

Fix for location issue is not deployed yet 😊

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sherry Chung pixel 5 is android 13. Sam Does this fixed will be include in ionic-v221129?

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung Yes it will be included

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam double confirm, ionic-v221115(0.69.2 ) contain this task?

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam Thanks, so I just use Oppo or Pixel 5 try it whether happened the location issue?

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung v221115 can not contain this task. It will be in next release.

I think confusion comes from that we have 2 types of upgrade. First minimal upgrade on android I did just to pass play store review.(fix for location issue is not included)

Second upgrade is full upgrade on android (including location library and other libraries.

So release v221115 does not contain fix for location issue.

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam (cc Sherry Chung) I got it, thanks for your explanation. I'll move this task to 1121 sprint.

[sync-by-unito[bot]]

➤ Sam commented:

This task is a duplicate of ✓ Updating from Capacitor 3 to Capacitor 4 ( https://app.asana.com/0/0/1203398058668097 ).

✓ Updating from Capacitor 3 to Capacitor 4 ( https://app.asana.com/0/0/1203398058668097 ) not only included Upgrade android API level but also some iOS changes related to capacitor 4 migration.