v230112-capture-app-ionic

[sync-by-unito[bot]]

﹍Product code:﹍

﹍Release milestone:﹍

﹍Testing level:﹍

﹍Release note:﹍

﹍Expectation:﹍

﹍Known Issue:﹍

﹍Limitation:﹍

﹍Test Link﹍:

﹍Note:﹍

﹍Testing Results (add this after QA test)﹍:

﹍Testing Plan (add this after QA test):﹍

Testing Levels:

• A. Full test + backward compatibility
• B. Full test, no backward compatibility
• C. Feature test
• D. Issue fix retest
• E. Growth

┆Issue is synchronized with this Asana Milestone by Unito ┆Created By: Tammy Yang

[sync-by-unito[bot]]

➤ Tammy Yang commented:

SamKenny Hung as our focus this week is to have a version ready for NUM migration ASAP. I suggest to push this release to Thursday so that Sam has ore time to prepare and make sure all modifications are correct.

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung release is submitted please have a look a slack thread for details. https://dt42-numbers.slack.com/archives/CUSDE44MD/p1673598728380889 ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1673598728380889 )

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam Please help to re-release, thanks. The testing note are below.

1. Terms of user & Data policy need to wait for iframe-v221227 deploy
2. The text below the Invite Friends can't be click ( https://app.asana.com/0/0/1203594105954143/1203770567277460/f )
3. The text below the Invite Friends should let user misunderstand ( https://app.asana.com/0/0/1203594105954143/1203770567277462/f )
4. Should flow the original delete account flow after backup private key. ( https://app.asana.com/0/0/1201181881071907/1203770618661430/f )
5. Log out button is disappear ( https://app.asana.com/0/0/1203594105954143/1203756223040237/f )

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, re-release submitted please have a look at https://dt42-numbers.slack.com/archives/CUSDE44MD/p1674029062110639?thread_ts=1674028997.047459&cid=CUSDE44MD ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1674029062110639?thread_ts=1674028997.047459&cid=CUSDE44MD )

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, re-release submitted for tomorrow morning https://dt42-numbers.slack.com/archives/CUSDE44MD/p1674043074459039 ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1674043074459039 )

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, I re-released the new firebase app distribution. version 0.73.1 (7) for iOS version 0.73.1 (7) for Android

This is the firebase app distribution release note for 0.73.1 (7) NOTE: this is just a pre-release version for QA (experimenting with the new flow).

0.73.1 (7) contains the following feats/fixes for v230112-capture-app-ionic

• [issue] "Collected" asset should not be edited the caption
• Update text from "gas fee" to "estimated gas fee"
• Fit figma - setting page
• [Sprint 2] Update Menu
• [FR] Ask user to backup private key and logout/login if "the change of backend user wallet is detected". OR when user press delete account

NOTE: during testing 0.73.1 (4) QA found some issues.

0.73.1 (7) also contains fixes for

• [fixed will work after iframe-v221227 is deployed ] Terms of user & Data policy need to wait for iframe-v221227 deploy
• [fixed] The text below the Invite Friends can't be click
• [fixed] Should flow the original delete account flow after backup private key.
• [fixed] Log out button is disappear
• [fixed] Terms of user page

[sync-by-unito[bot]]

➤ Tammy Yang commented:

Kenny Hung according to the new process, we have the following steps:

1. Pre-release (APK and Firebase, all connected to storage-backend and network-action production sites) << by Dev
2. Tests for pre-release << by QA
3. Run code review with CharGPT << by Dev
4. Code review and merge into develop << by Reviewer
5. Release develop branch << We are now here
6. Tests for merged release << by QA
7. Issue fix if any (expect to be minimum) << by Dev, ChatGPT and Reviewer
8. Merge to master << by Release manager

Steps 1~5 are all done. Please continue the official test for this release.

[sync-by-unito[bot]]

➤ Tammy Yang commented:

Sam there are 3 unfinished issues in this milestone, please suggest what shall we do with them.

1. Propose design for Capture transaction details ( https://app.asana.com/0/1203615853062031/1203610962578674 )
2. Minimize API calls to reduce cost & speed up app performance ( https://app.asana.com/0/1203615853062031/1202222881193688 )
3. Add a FAQ page in capture app (It will be added below About page.) ( https://app.asana.com/0/1203615853062031/1203232866915326 )

[sync-by-unito[bot]]

➤ Sam commented:

Tammy Yang commented under each task

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam (cc Tammy Yang) QA can't see the app on google play & testflight. Are there any steps I missed?

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung somebody released a build? I didn't do anything related to releases.

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam According to the new process, we have the following steps: #1-#8 QA has received the v230112-ionic release ( https://airtable.com/app4oLOHhBT06Hivf/tblcLcxnayIP3LXji/viwkmgJXkJbyMiIGT/recAILI3gFmuvNRzA?blocks=hide ), so should be able to test it on google play / testflight instead of another way. Or do I misunderstand?

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, yes correct. v230112 is submitted by Tammy Yang, let me check git commits first.

[sync-by-unito[bot]]

➤ Sam commented:

Tammy Yang, I see branch milestone-v230112 is merged to develop branch.

But to generate and upload APK/IPA files to PlayStore/TestFlightdevelop should be merged with master according to this miro ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764542656055086&amp;cot=14 ) and once develop and master are merged successfully we can submit the release to QA (at least that's what bofu was doing 😅🙏)

Kenny Hung, it's correct that you don't see anything in TestFlight & Google Play. Need to wait for Tammy Yang. 🚀

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Tammy YangBofu Chen (cc Sam) QA doesn't receive the capture app(0.73.x) on testflight & google play.

[sync-by-unito[bot]]

➤ Bofu Chen commented:

Sam Can you help also updating the package building files (packages.json, etc.), so that the release manager (Tammy) only needs to add a tag to trigger the CI build? Thanks!

[sync-by-unito[bot]]

➤ Sam commented:

Bofu Chen, sure I just want to double check. I just need to bump build in package.json file in branch milestone-v230112 ( https://github.com/numbersprotocol/capture-lite/pull/2515 ) right?

Should I also update CHANGELOG.md?

[sync-by-unito[bot]]

➤ Bofu Chen commented:

Sam Yes for the 2 questions 👍

[sync-by-unito[bot]]

➤ Sam commented:

Tammy Yang (cc: Bofu Chen) here is the PR ( https://github.com/numbersprotocol/capture-lite/pull/2532 ) with bump and changelog update, for milestone-v230112 tag should be 0.73.1.

[sync-by-unito[bot]]

➤ Bofu Chen commented:

Sam Why the version numbers is 0.73.1 instead of 0.73.0?

[sync-by-unito[bot]]

➤ Sam commented:

Bofu Chen, it could be 0.73.0 but in order to not to confuse QA I choose 0.73.1 because in firebase app distribution I used 0.73.1

[sync-by-unito[bot]]

➤ Sam commented:

Bofu Chen, when I was first publishing to firebase app distribution it was new to me so I just pick 0.73.1 but from now on I will make sure next version will be something like 0.74.0

[sync-by-unito[bot]]

➤ Sam commented:

Bofu Chen, also I learned something and has suggestion to unify app versioning.

For example on Android we always have

• versionCode 471
• versionName "0.73.1"

Same app version in iOS will be

• MARKETING_VERSION = 0.73.1;
• CURRENT_PROJECT_VERSION = 2;

So maybe in the future we can do something like Android

• versionCode 471
• versionName "0.73.1"

iOS

• MARKETING_VERSION = 0.73.1;
• CURRENT_PROJECT_VERSION = 471;

It can benefit QA so they will not confuse.

[sync-by-unito[bot]]

➤ Bofu Chen commented:

Sam The proposal looks good to me. Let's update the iOS project version in the next release.

[sync-by-unito[bot]]

➤ Bofu Chen commented:

The GitHub CI is building 0.73.1: https://github.com/numbersprotocol/capture-lite/actions/runs/4043062429 ( https://github.com/numbersprotocol/capture-lite/actions/runs/4043062429 )

[sync-by-unito[bot]]

➤ Bofu Chen commented:

Tammy Yang In the future, you can trigger Capture CI to build and upload the Android/iOS apps to the stores by using the commands

git checkout develop
git pull
git checkout master
git merge develop
git push origin master
git tag -s -a 0.74.0
git push —tags

The condition of triggering Capture CI is to push a version tag to the master branch.

Note: if you push a tag to any branch, Capture CI will also be triggered actually.

[sync-by-unito[bot]]

➤ Bofu Chen commented:

Sam It seems that the iOS action of Capture CI has not been fixed.

https://github.com/numbersprotocol/capture-lite/actions/runs/4043062429/jobs/6951529932 ( https://github.com/numbersprotocol/capture-lite/actions/runs/4043062429/jobs/6951529932 )

Please help upload the iOS app manually before the action is fixed. Thanks

[sync-by-unito[bot]]

➤ Bofu Chen commented:

Created Fix iOS action of Capture CI ( https://app.asana.com/0/1201016280880500/1203850867838308/f ) and added it as dependency of v230207

[sync-by-unito[bot]]

➤ Bofu Chen commented:

Kenny Hung The Android build should be available on store now. Sam will ping you after uploading the iOS build manually.

[sync-by-unito[bot]]

➤ Sam commented:

Done, iOS is coming too.

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Tammy Yang (cc SamSherry Chung) ionic-v230112 is QA passed.

1. The text below the Invite Friend(Menu list) maybe let users misunderstand. Because the current rule needs new users to finish the verification step then get the credits. → I think this part could be changed by backend. It's not release blocker.