numbersprotocol / capture-lite

A photo-sharing app with only verifiable photos and videos.
https://numbersprotocol.github.io/
GNU General Public License v3.0
25 stars 6 forks source link

v230209-capture-app-ionic #2514

Closed sync-by-unito[bot] closed 1 year ago

sync-by-unito[bot] commented 1 year ago

﹍Product code:﹍

﹍Release milestone:﹍

﹍Testing level:﹍

﹍Release note:﹍

﹍Expectation:﹍

﹍Known Issue:﹍

﹍Limitation:﹍

﹍Test Link﹍:

﹍Note:﹍

﹍Testing Results (add this after QA test)﹍:

﹍Testing Plan (add this after QA test):﹍

Testing Levels:

┆Issue is synchronized with this Asana Milestone by Unito ┆Created By: Bofu Chen

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam (cc Tammy Yang) QA haven't received the pre-release(v230209 firebase) yet.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, firebase release is submitted. https://dt42-numbers.slack.com/archives/CUSDE44MD/p1676455363600569 ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1676455363600569 )

Firebase release 0.75.0(1) contain fixes/features for v230209-capture-app-ionic:

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, firebase release is submitted. https://dt42-numbers.slack.com/archives/CUSDE44MD/p1677044681538319 ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1677044681538319 )

Firebase release 0.75.1(1) contain fixes/features

NOTE: 0.75.1(1) also contains fixes/features from firebase 0.75.0(1)

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam (cc Scott YanSherry Chung) QA doesn't get v230209-ionic the official release yet. I have already see the release note submit, but google play/testflight doesn't see that.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Tammy Yang, can you please approve PR ( https://github.com/numbersprotocol/capture-lite/pull/2646 ) (merge develop to master) once it's done I will create tag 0.75.0 from master branch and it should kickoff TestFlight/PlayStore builds.

Before we used release-branch ( https://github.com/numbersprotocol/capture-lite/pull/2646 ) to kickoff build but now I think we just

  1. merge develop with master
  2. tag master with 0.XX.X version and push that tag
  3. TestFlight/PlayStore builds are triggered.
  4. QA receives TestFlight/PlayStore apps for testing
sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Or maybe Bofu Chen? 😅

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, once this PR ( https://github.com/numbersprotocol/capture-lite/pull/2646 ) is merged I will push tag 0.75.0 and trigger TestFlight/PlayStore builds.

sync-by-unito[bot] commented 1 year ago

➤ Bofu Chen commented:

Sam I've accepted the PR, and you can attach the version tag to trigger the CI now.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, builds ready. For Android it's done. For iOS I manually uploaded (TestFlight is processing should be ready soon)

https://app.asana.com/app/asana/-/get_asset?asset_id=1204104896176643 ( https://app.asana.com/app/asana/-/get_asset?asset_id=1204104896176643 )

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung release reminder submitted ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1678208945893379 ) 🚀.

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Tammy Yang needs your help for Comment by @Kenny Hung on Deploy "version-v230207-sam" branch ( https://app.asana.com/0/0/1204114808870358/1204126355686596/f ) QA have received the new official release from Sam, but FAQ page needs to deploy, then QA could finish this test.

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam (cc Tammy YangSherry ChungScott Yan) official release 0.75.1 still fail, because [Issue] After user record the video, user press "Next" but nothing happened. ( https://app.asana.com/0/1201083422707776/1204151390107966/f ) This issue is testing-blocker because user can't record the video.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, will work on it now. Kenny Hung, quick question [Issue] After user record the video, user press "Next" but nothing happened. ( https://app.asana.com/0/1201083422707776/1204151390107966 ) didn't occured on firebase release?

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Yes, also happened on firebase.

sync-by-unito[bot] commented 1 year ago

➤ Tammy Yang commented:

Kenny Hung I think the key here is:

If the issue happened before, it should not block the release. Please confirm which one is the case

A. The issue ONLY exist in 0.75.1 but not any older release. However, QA did not realize the issue during the firebase release B. The issue does NOT only exist in 0.75.1 and can also be found in the older release.

sync-by-unito[bot] commented 1 year ago

➤ Tammy Yang commented:

Kenny Hung (cc Scott YanSherry Chung as it is an overall process issue)

We have 0209, v230223 ( https://app.asana.com/0/1201016280880500/1203890451628436/f ), and v230310 ( https://app.asana.com/0/1201016280880500/1204010561520024/f ) coming soon. It cannot be like this 😅, we will have endless releases in the queue very soon.

For now, please

  1. Find the shortest path to ensure 0209 can pass the QA test, provide proposal and discuss with dev that how it can pass ASAP.
  2. Make sure 0209 is deployed to App Store and Google Play no later than next Wednesday
  3. Merge 0223 and 0310 into one release

In the future, please help make sure the same situation won't happen again. If there are already two releases in the queue, digesting the old releases will be first priority. In that case, QA needs to work with Dev closely to solve the issues asap. Please take actions (like hosting Huddle to explain the issue) instead of leaving messages on Asana. It is too slow and not an ideal approach when there are already two releases in the queue.

Thank you!

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Tammy Yang (cc Sam) Got it. Thanks for handling this situation. This issue is #A It doesn’t happened on current public version, so this is the block issue. I don’t find it on firebase process it’s because I miss testing blocker test items on firebase process. In the future, QA will make sure test new features + all testing blocker are passed then could enter next process.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, I fixed the camera issue.

I checked previous changes and there was no changes to camera plugin during 0.74.x - 0.75.x but the I looked at pre-publish page.

It was simple bug when user click confirm button I forgot to check if it's video. Basically on confirm:

https://app.asana.com/app/asana/-/get_asset?asset_id=1204158284131854 ( https://app.asana.com/app/asana/-/get_asset?asset_id=1204158284131854 )

Let me know if we can add it as hotfix or still should add to next release.

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam (cc Tammy YangSherry ChungScott Yan) I see Comment by @Sam on v230209-capture-app-ionic ( https://app.asana.com/0/0/1203835045290878/1204158284131855/f ) Please help to re-release v230209-ionic on testflight/google play ASAP. It’s the highest priority, we need to public before Wednesday.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

https://github.com/numbersprotocol/capture-lite/tree/milestone-v230209-hotfix-video-publish ( https://github.com/numbersprotocol/capture-lite/tree/milestone-v230209-hotfix-video-publish ) is ready ✅.

Next steps:

  1. merge hotfix to develop (need Tammy Yang approval)
  2. merge develop to master (need Tammy Yang permissions)
  3. tag master with 0.75.2 (Sam)
  4. kickoff and make sure App/Play store are uploaded ( Sam)
  5. make sure hotfix is working (QA)
  6. release to public
sync-by-unito[bot] commented 1 year ago

➤ Bofu Chen commented:

Sam steps 1 & 2 are completed, and you can keep going from step 3 now.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, 0209 (0.75.2) is available ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1678760083272809 ) for testing at App/Play stores