numbersprotocol / capture-lite

A photo-sharing app with only verifiable photos and videos.
https://numbersprotocol.github.io/
GNU General Public License v3.0
25 stars 6 forks source link

v230310-capture-app-ionic(merge v230223) #2609

Closed sync-by-unito[bot] closed 1 year ago

sync-by-unito[bot] commented 1 year ago

﹍Product code:﹍

﹍Release milestone:﹍

﹍Testing level:﹍

﹍Release note:﹍

﹍Expectation:﹍

﹍Known Issue:﹍

﹍Limitation:﹍

﹍Test Link﹍:

﹍Note:﹍

﹍Testing Results (add this after QA test)﹍:

﹍Testing Plan (add this after QA test):﹍

Testing Levels:

┆Issue is synchronized with this Asana Milestone by Unito ┆Created By: Kenny Hung

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam (cc Tammy YangScott Yan) I found this release is overdue, please make sure to complete the critical & High tasks first. About

  1. [issue] back button will back to wrong page (should in the explore tab not my capture tab) ( https://app.asana.com/0/0/1203600983882519/f )
  2. communicate bubble auth changes to ionic side ( https://app.asana.com/0/0/1203901366913919/f )
  3. For first-time user, only ask login/sign up when they try to use camera or MyCapture page ( https://app.asana.com/0/0/1203572773341290/f )

If you have almost done, I think you could just continue finishing it. Otherwise, I suggest rescheduling the medium tasks. Please help to confirm which tasks need to reschedule and the new due could be today or tomorrow?

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung (cc: Tammy Yang),

  1. Today I spent most time on [issue] back button will back to wrong page (should in the explore tab not my capture tab) ( https://app.asana.com/0/0/1203600983882519 ) seems like it's not simple issue. I explained more on this comment ( https://app.asana.com/0/0/1203600983882519/1204142108316918/f ) and previous comments.
  2. I will try today and tomorrow (if can not finish lets reschedule)
  3. I will try today and tomorrow (if can not finish lets reschedule)
sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam Okay, I got it. How about Fix iOS action of Capture CI: Fail to upload IPA to TestFlight ( https://app.asana.com/0/1201016280880500/1204000153100425/f ) ?

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, I will look at it today too Fix iOS action of Capture CI: Fail to upload IPA to TestFlight ( https://app.asana.com/0/0/1204000153100425 ) but this task does not effect our user.

it just prevent automatic TestFlight upload. And if necessary I can upload manually just like before.

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam (cc Tammy YangScott YanSherry Chung) as mentioned on Comment by @Tammy Yang on v230209-capture-app-ionic ( https://app.asana.com/0/0/1203835045290878/1204158112528837/f )

  1. Please merge 0223 ( https://app.asana.com/0/1201016280880500/1203890451628436/f )and 0310 into one release. (Maybe the firebase version should be 0.77.0?)
  2. Incompleted items, I suggest reschedule them.
    1. communicate bubble auth changes to ionic side ( https://app.asana.com/0/1203916996565664/1203901366913919 )
    2. For first-time user, only ask login/sign up when they try to use camera or MyCapture page ( https://app.asana.com/0/1203916996565664/1203572773341290 )
    3. Fix iOS action of Capture CI: Fail to upload IPA to TestFlight ( https://app.asana.com/0/1203916996565664/1204000153100425 )

If there is any question or concern, please let me or Tammy know, thanks.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung,

  1. Sure I can merge 0223 ( https://app.asana.com/0/1201016280880500/1203890451628436 )and 0310 into one release and re-publish on firebase as 0.77.0
  2. Regarding reschedule.
    1. For first-time user, only ask login/sign up when they try to use camera or MyCapture page ( https://app.asana.com/0/1201016280880500/1203572773341290 )(lets reschedule)
    2. communicate bubble auth changes to ionic side ( https://app.asana.com/0/1201016280880500/1203901366913919 )(lets reschedule)
    3. Fix iOS action of Capture CI: Fail to upload IPA to TestFlight ( https://app.asana.com/0/1201016280880500/1204000153100425 ) (I can include it in 0.77.0 release)

Let me know what you think 🤔

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung when reschedule lets change communicate bubble auth changes to ionic side ( https://app.asana.com/0/1201016280880500/1203901366913919 ) as bubble task.

Original feature was to implement lazy login. To implement lazy login we need 2 task.

So communicate bubble auth changes to ionic side ( https://app.asana.com/0/0/1203901366913919 ) is bubble task. Ethan Wu already knows ( https://app.asana.com/0/0/1203901366913919/1204151530930032/f ) what to do from bubble side. We just need to change it as bubble task and include to some bubble release. Hope it make things clear. If any questions please let me know.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung here is the release-reminder ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1678779938620429 )for v230310-capture-app-ionic (firebase)

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam (cc Tammy YangSherry Chung) 0.77.0 firebase test pass. issue summary

  1. FAQ page can't work. (Because FAQ page doesn't deploy yet.) CP
  2. [Issue] When user registers the account but user inputs the existing name, the error message is wrong. ( https://app.asana.com/0/1201083422707776/1204125871819015/f )
  3. When [issue] The video audio will play automatically on the asset detail page ( https://app.asana.com/0/1201016280880500/1203323958230173/f ) fixed. In some cases, the detail page will be weirder than before. → I suggest could be fixed in the patch sprint. detail example. If user has 2 asset A, B. A is video asset, B is photo. When user enters to B asset page, will hear the A video asset sound. The root cause is [issue] The video audio will play automatically on the asset detail page ( https://app.asana.com/0/1201016280880500/1203323958230173/f ).

Additional information

  1. testing blocker items doesn't include app update testing, this item needs to test on the official release.
sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

[issue] The video audio will play automatically on the asset detail page ( https://app.asana.com/0/1201016280880500/1203323958230173 ) I think it might be iframe side I think we can just set auto play mute and it should fix

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam (cc Tammy Yang) Just remind, QA doesn't received the ionic-v230310 official release. As schedule it should be release today, if it needs to postpone, please let QA know. Thanks.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, currently I'm working on [FR] asset saved to device camera roll (Can save the Captures to local) ( https://app.asana.com/0/0/1203277148217555 ).

We might need to postpone, can we postpone to Thursday (Mar 23)?

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam Okay, I add a sub-task for this. Please help to make sure Tammy Yang could start code review.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, according to new flow I believe Tammy Yang does code review only if it passes Firebase testing. 😅

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, sorry I thought it was card for v230321. Sure I will prepare code review PRs for Tammy tomorrow.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

App/PlayStore release reminder submitted ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1680504808211899 ).

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam (cc Tammy YangScott YanSherry Chung)

0.77.0 is fail, issue summary

  1. [issue] Delete account should work real ( https://app.asana.com/0/1201016280880500/1203292734517496 )

  2. [Issue] When asset registration is incomplete, the asset page will repeatedly reload. ( https://app.asana.com/0/1201083422707776/1204353479020081 ) -> Conditional Pass, will fixed it in the future sprint.

  3. [Issue] web3 storage network action result url can't work ( https://app.asana.com/0/1201083422707776/1204352746066559 ) → Only affect users who want to operate web3.0 storage. QA will check again on 4/10 (Mon).

Because #1 is one of the new features in this version, 0.77.0 is fail.

sync-by-unito[bot] commented 1 year ago

➤ Tammy Yang commented:

Kenny Hung for #1, I think Bofu Chen and Sam are already handling. Let's give them a bit time?

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Once the PR from Comment by @Sam on [issue] Delete account should work real ( https://app.asana.com/0/0/1203292734517496/1204353785292963/f ) is approved it will take another 10-15 minutes to build be completed and re-deployed to TestFlight/PlayStores.

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Tammy Yang It's okay, so I'll test them next Monday & set this item first priority.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, release reminder submitted ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1680871692419559 ).

0.77.1 contains everything from 0.77.0 + Hotfix for delete account.

You can always refer to CHANGELOG.md ( https:// https://github.com/numbersprotocol/capture-lite/blob/master/CHANGELOG.md ).

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

SamTammy Yang (cc Scott YanSherry Chung)

0.77.1 after general test & user test

About #1 uploading issue, QA think could be conditional pass, but need Tammy's confirmation.

issue summary

  1. About new upload feature has 3 issues

    1. [Issue] Only iOS - user could upload the duplicate photo ( https://app.asana.com/0/1201083422707776/1204361832181074/f ) -> Conditional pass. Currently found on iOS & can’t reproduce every time, the ratio is about 20%.
    2. [Issue] Error handling for uploading duplicate photo ( https://app.asana.com/0/1201083422707776/1204361832181061/f ) -> QA think could Conditional pass, and suggest maybe could fix into next sprint.
    3. [Issue] When user tries uploading the photo which is under the another account, user will stuck in the register processing ( https://app.asana.com/0/1201083422707776/1204361832181068/f ) -> Conditional Pass, because we assume user uses 1 account. Could fix in the future sprint.
  2. [Issue] When asset registration is incomplete, the asset page will repeatedly reload. ( https://app.asana.com/0/1201083422707776/1204353479020081/f ) -> Conditional Pass, will fixed it in the future sprint.

  3. [Issue] web3 storage network action result url can't work ( https://app.asana.com/0/1201083422707776/1204352746066559/f ) -> It’s about network action part.

  4. [Issue] When user edit the caption and back to asset page, user needs to press back button more 4 times then could be back to mycapture tab. ( https://app.asana.com/0/1201083422707776/1204361090819840/f ) → conditional pass.

sync-by-unito[bot] commented 1 year ago

➤ Tammy Yang commented:

Kenny Hung

1.1 need to fix

1.2 OK

1.3 OK

  1. need to fix

  2. OK

  3. schedule in the next sprint

sync-by-unito[bot] commented 1 year ago

➤ Tammy Yang commented:

Kenny Hung questions: why these issues were not found in the pre-test? I think we expect most critical issues are found in the pre-test

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Tammy Yang I think it's because the pre-test may not be as thorough since some issues require multiple tests to find, such as 1.1 or 2.

Going forward, we could utilize ChatGPT to generate more comprehensive testing scenarios for new features and swiftly discuss them with Scott beforehand. This will enable us to uncover more critical issues during pre-tests in the future.

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam Please fix it, and re-release new official release(0.77.2)

1.1 [Issue] Only iOS - user could upload the duplicate photo ( https://app.asana.com/0/1201016280880500/1204361832181074/f )

2 [Issue] When asset registration is incomplete, the asset page will repeatedly reload. ( https://app.asana.com/0/1201016280880500/1204353479020081/f )

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Tammy YangSam (cc Sherry ChungScott Yan)

0.77.3 firebase still failed. (0.77.2 fail could refer here ( https://app.asana.com/0/0/1202610504277074/1204386915711048/f ))

  1. [Issue] Only iOS - user could upload the duplicate photo [Issue] Only iOS - user could upload the duplicate photo ( https://app.asana.com/0/1201016280880500/1204361832181074/f ) -> Still doesn't fix
  2. [Issue] Entering an incomplete asset page through swiping will only show the loading icon. [Issue] Entering an incomplete asset page through swiping will only show the loading icon. ( https://app.asana.com/0/1201083422707776/1204386681282345/f ) -> conditional pass
  3. [Issue] (Specific device) Sometimes take a whole black image [Issue] (Specific device) Sometimes take a whole black image ( https://app.asana.com/0/1201016280880500/1204378124620259/f ) -> conditional pass
  4. [Issue] When user tries uploading the photo which is under the another account, user will stuck in the register processing -> Conditional Pass, because we assume user uses 1 account. Could fix in the future sprint.
  5. [Issue] web3 storage network action result url can't work -> It’s about network action part.
  6. [Issue] (Specific device) After edit caption, will be lead to mycapture tab instead of asset detail page ( https://app.asana.com/0/1201083422707776/1204389590719132/f )
  7. [Issue] When user edit the caption and back to asset page, user needs to press back button more 4 times then could be back to mycapture tab. → conditional pass.
  8. The Privacy Policy on create account page could link to iframe page will be better ( https://app.asana.com/0/1201083422707776/1204378124620264/f )

The blocker only #1

Additional need to notice

  1. In order to fix [Issue] When user edit caption & save update, the asset page could display the new updated caption automatically. ( https://app.asana.com/0/1201016280880500/1204386834167179/f )Sam use workaround ( https://app.asana.com/0/1201016280880500/1204388460792883/f ).
  2. Sam may re-release 0.77.4 tomorrow, so the v230310 public must postpone to next week.
sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam (cc Tammy YangBofu ChenJames ChienScott Yan) According to Comment by @Bofu Chen on [Issue] Only iOS - user could upload the duplicate photo ( https://app.asana.com/0/0/1204361832181074/1204410638696061/f )

Please send code review based on 0.77.2.

[Issue] Only iOS - user could upload the duplicate photo ( https://app.asana.com/0/1201016280880500/1204361832181074 )will push to v230413-capture-app-ionic ( https://app.asana.com/0/0/1204223578973623 ).

sync-by-unito[bot] commented 1 year ago

➤ Bofu Chen commented:

[@Kenny Hung](Kenny Hung) Could you remind me where to find all the conditional passed issues? It seems that we have many of them which will be a potential trouble in the future.

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Bofu Chen You could check sprint backlog first.

Normally, if a task is not planned in an existing sprint, it will be added to the sprint backlog. If its priority is low, it might be placed in the product backlog.

sync-by-unito[bot] commented 1 year ago

➤ Tammy Yang commented:

Kenny Hung (cc Scott Yan) If the issues are identified are "critical" and must be fixed, the HAVE to be added to the milestone card. If not yet, please fix. Thank you!

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Related to this milestone:

Tammy Yang please check this small PRs for code review.

(cc: Kenny Hung)

milestone-v230310(0.77.2) ( https://github.com/numbersprotocol/capture-lite/tree/milestone-v230310(0.77.2) ) branch contains 2 PRs

Once 2PRs are approved I will

Side note milestone-v230310(0.77.2) ( https://github.com/numbersprotocol/capture-lite/tree/milestone-v230310(0.77.2) ) is the one that has lower rate for duplicate uploads and also passed QA + CodeReview previously and contains

sync-by-unito[bot] commented 1 year ago

➤ Tammy Yang commented:

Sam done, please continue.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Was about to write this

Tammy according to new flow ( https://dt42-numbers.slack.com/archives/C3CHPJTS4/p1680861795762459 ) we do not merge milestone branch to develop anymore.

So for milestone-v230310(0.77.2) ( https://github.com/numbersprotocol/capture-lite/tree/milestone-v230310(0.77.2) ) I

Once you approve PR I will push the tag 0.77.2 that will trigger

But Bofu Chen already approved merge thank you for speed 🙏. Once it finishes lint and test I will push the tag and notify QA.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, (cc: Tammy Yang, Bofu Chen):

Release reminder submitted ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1681821352185049 ).