numbersprotocol / capture-lite

A photo-sharing app with only verifiable photos and videos.
https://numbersprotocol.github.io/
GNU General Public License v3.0
25 stars 6 forks source link

bubble update for showing order information(order detail) in the transaction #2624

Closed sync-by-unito[bot] closed 1 year ago

sync-by-unito[bot] commented 1 year ago

design detail

  1. Both Transaction Detail and Order Detail will be replaced by Bubble.
  2. The current Network Actions feature will be renamed to “Order.”
  3. The Order tab will now include the Asset Register Order.

Proposed design update: ✓ Propose design for Capture transaction details

according to this comment we implement it via bubble.

┆Issue is synchronized with this Asana task by Unito ┆Created By: Tammy Yang

sync-by-unito[bot] commented 1 year ago

➤ Ethan Wu commented:

Sam delete the existing qa-release branch and create a new branch from your working branch called qa-release

the reason why we do this is because bubble merge can be pretty hit or miss. better to just clone instead of do merge

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung done it can be tested in qa-release branch. Example URL ( https://captureappiframe.numbersprotocol.io/version-qa-release/order_details?order_id=00d7341d-f23f-41d0-b152-2a79cc995993&asset_id=bafkreicxauc5ftvigtynl64nk6wgt3yvd7r22eeg32b6krjsdjccz3e77e ).

I will submit reminder-release in a moment.

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam (cc Tammy Yang)

  1. Order id of this page ( https://captureappiframe.numbersprotocol.io/version-qa-release/order_details?order_id=645eb4c0-3b56-49fc-9c6e-2a496439a2cc&asset_id=bafybeihzsibu2iblysl7wlovvwmma6qovewolhxlo5bxdildkssad2nkfu ) only support transaction id or network app order id or both of them? I try transaction id, it seems the information is wrong.
  2. Will this page replace current network actions order detail or CAPTURE TRANSACTIONS detail? Because the miro said order id should be transaction id instead of network app id

https://app.asana.com/app/asana/-/get_asset?asset_id=1204297279320780 ( https://app.asana.com/app/asana/-/get_asset?asset_id=1204297279320780 )

  1. It doesn't have "VIEW YOUR COLLECTION"
sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung

  1. it MUST pass network app order id and asset id
  2. according to Miro it’s used inside capture app only.
  3. Yes it does not show as of now (need to specify what will happen when click view your collection butting is clicked
sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

I think I need to confirm with Tammy Yang and Sam first, https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764550347336631&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764550347336631&cot=14 )

https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764550347336631&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764550347336631&cot=14 )

  1. Both Transaction Detail and Order Detail will be replaced by Bubble.
  2. The current Network Actions feature will be renamed to "Order."
  3. The Order tab will now include the Asset Register Order.

Can you please let me know if my understanding is correct with both Tammy and Sam before we proceed?

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, additionally to your questions I also want to add mine.

  1. what will happen when click view your collection butting is clicked?
  2. Need to confirm with Tammy Yang, is this bubble page will be used inside capture app only?
sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam (cc Tammy Yang)

As I know

1, when user click "view your collection" will lead to mycapture tab "COLLECTED"

https://app.asana.com/app/asana/-/get_asset?asset_id=1204298777974535 ( https://app.asana.com/app/asana/-/get_asset?asset_id=1204298777974535 )

2, As I know, it should be yes. iframe is a part of capture app.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, summary of huddle ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1680240063443489 ).

As a next step for order details bubble page (will work network app order ids only)

  1. change price to include (Total cost, Fee, Gas Fee)
  2. add copy icon near order id
  3. add result url

I will work on 1, 2, 3 now and submit for QA testing today.

Please let me know if I missed anything.

sync-by-unito[bot] commented 1 year ago

➤ Tammy Yang commented:

Sam thanks for the summary!

Regarding #1, do you think if we can have something like the attached photo? We show only the total sum of product price + gas, then if user click the button, UI will expand and show more information.

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Tammy Yang, sure I can try it, and I think it's look better on UI side as well. Thank you for hint.🙏

sync-by-unito[bot] commented 1 year ago

➤ Tammy Yang commented:

Like this https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764550447250979&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764550447250979&cot=14 )

https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764550447250979&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764550447250979&cot=14 )

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Tammy Yang, what is the name of this collapsable text component (How do I calculate monthly income)? Is it ready component or?

https://app.asana.com/app/asana/-/get_asset?asset_id=1204306084904602 ( https://app.asana.com/app/asana/-/get_asset?asset_id=1204306084904602 )

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Tammy Yang, I think I found ( https://bubble.io/video/how-to-collapse-group-heights ) similar thing it please ignore last message. 🙏

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, need your confirmation.

Order details can not be show if asset was deleted?

Scenario

  1. I take photo (create capture)
  2. I run mint and share on photo from step 1
  3. Go to activities > Orders (previously Network actions)
  4. Open order details for Mint & Share from step 2
  5. I can see order details + asset details (img etc) [work as expected 🟢]
  6. I delete photo
  7. Go to activities > Orders (previously Network actions)
  8. This time order does not have thumbnail
  9. Open order details for Mint & Share from step 2
  10. What should I show if order details was deleted?

Current behavior just show asset not found or not accessible by user (see video attached)

sync-by-unito[bot] commented 1 year ago

➤ Kenny Hung commented:

Sam I think this part also need to confirm with Tammy Yang

I suggestion still could show the information.

But if there is limitation, we could just show the current error message and find the solution later.

How about you? SamTammy Yang

sync-by-unito[bot] commented 1 year ago

➤ Sam commented:

Kenny Hung, I fixed and for now order details can show even if asset was deleted.

Preparing QA release 🚀