[Sprint 1] Edit profile

[sync-by-unito[bot]]

┆Issue is synchronized with this Asana task by Unito ┆Created By: Tammy Yang

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, Where user will enter "Edit profile" page?

Is it from menu? Or..?

[sync-by-unito[bot]]

➤ Sam commented:

Because currently there are 2 buttons instead of Edit Profile

[sync-by-unito[bot]]

➤ Kenny Hung commented:

SamTammy Yang

This is my proposal

Press "username" to enter edit profile page & add a icon near the username let user know this place can be pressed.

Because in the Figma design mockup, "Activities" and "Inbox" have been removed, but we still need to retain these two positions, I suggest accessing them via the username. This also aligns with the current UX (clicking the username to change it).

How do you think?

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, Thank you for proposal, I think it is a good idea. Will implement that. 🙏

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam (cc Tammy YangScott Yan)

For profile edit page, please help to fix these below & re-release

1. The edit icon on mycapture tab appears oddly.

1. The edit page title is not centered.

1. The limitation of the username is displayed incorrectly.
   1. reference ( https://docs.google.com/spreadsheets/d/1tC9YOFjozxjo77PhstFjyOO0O9wat17UqhaofeT_Poo/edit#gid=654354700 )

1. The username error message(too long) is incorrect.

   1. https://docs.google.com/spreadsheets/d/1tC9YOFjozxjo77PhstFjyOO0O9wat17UqhaofeT_Poo/edit#gid=654354700 ( https://docs.google.com/spreadsheets/d/1tC9YOFjozxjo77PhstFjyOO0O9wat17UqhaofeT_Poo/edit#gid=654354700 )

2. The description differs from what's shown in Figma.

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Additional information, the limitation of description is 250 characters.

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung tomorrow morning fixed firebase re-release will be ready for testing.

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, regarding edit icon on iOS can you specify what is exactly wrong with it?

I tried on iOS and it looks ok to me. But if you can specify exactly what is wrong the I can change it accordingly. 🙏

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, I tried to add character count but it's not supported by library we are using it might require a lot of dirty code to make it work.

Option 1

• ask ngx-formly ( https://github.com/ngx-formly/ngx-formly ) devs to add support for character count. (might take long time and since we are using old version 5 they might not event approve this feature)

Option 2

• make description input taller (see video) in attachements

Option 3

• write custom input field with character count like in Figma design but needs more time.

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam

For iOS icon display issue, it seems to display a little weird. It display a little differently with android. Do you try on an actual iOS device?

For "The description differs from what's shown in Figma."

Tammy Yang this part needs your confirmation, I think option 2 is good! If you agree, I'll notify Noir about this change. (Also ping you on slack ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1694572763050709 ).)

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam For your proposals

Please use option2.

For icon part, do you need additional support?

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam

1. (Only on iOS) The edit icon on mycapture tab appears oddly. It's still here. Maybe we could change this part, using press the username then enter the edit profile page.
2. The edit page title is not centered.

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, I will quickly fix and re-publish today.

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, can you please send screenshot for "The edit icon on mycapture tab appears oddly"

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, I'm using iPhone 6s+, and can not reproduce. What I do is just use system icon. So there is nothing I can do from my side.

Or we can choose another icon (screenshot from iPhone 6s+)

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung, is edit icon look oddly in other iPhones too?

[sync-by-unito[bot]]

➤ Sam commented:

I center "Edit profile".

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam

I test both iPhone 8 & iPhone 12 pro, they have this issue.

[sync-by-unito[bot]]

➤ Sam commented:

Kenny Hung regarding edit icon I can propose the following

1. Report to ionic team that on some iPhones "edit" icon is showing oddly and wait untill they release the fix (too long to wait)
2. Use another icon Comment by @Sam on [Sprint 1] Edit profile ( https://app.asana.com/0/0/1203634212778011/1205497932431249/f )
3. Or ask noir team to create branded icon for edit profile.

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Sam I suggest we could use this one.

https://iconduck.com/icons/178293/edit ( https://iconduck.com/icons/178293/edit )

Due to capture brand book, the base icon we use from open source from "piqo.design"

This link is also from them & it has edit icon.

[sync-by-unito[bot]]

➤ Kenny Hung commented:

Let me know if you have any question, thanks.

[sync-by-unito[bot]]

➤ Kenny Hung commented:

It looks great.

[sync-by-unito[bot]]

➤ Sam commented:

Prepearing 0.85.2 firebase release

• fix "Edit profile" center text
• fix edit icon.

Release Will be ready in 10 mins

[sync-by-unito[bot]]

➤ Kenny Hung commented:

QA test pass.