numbersprotocol / capture-lite

A photo-sharing app with only verifiable photos and videos.
https://numbersprotocol.github.io/
GNU General Public License v3.0
25 stars 6 forks source link

[Issue] fix deploy-to-android-GitHub CI #3121

Closed sync-by-unito[bot] closed 11 months ago

sync-by-unito[bot] commented 11 months ago

Description

GitHub actions for ﹍deploy-play-store﹍ are failing.

Release uses an old version of Google Play Billing," suggests that there is an issue with the version of Google Play Billing used in your Android app. Google Play requires that apps use the latest version of Google Play Billing to ensure that they are compliant with the latest billing and security standards.

https://developer.android.com/google/play/billing/integrate

Reminder

1. Starting on August 2, 2023, all new apps must use Billing Library version 5 or newer. By November 1, 2023, all updates to existing apps must use Billing Library version 5 or newer. ﹍Learn more﹍.

2. If your app is targeting Android 14 or higher, you must update to ﹍PBL 5.2.1﹍ or ﹍PBL 6.0.1﹍ or higher.

Logs

For logs you can check deploy-play-store action from ﹍Merge pull request #3120 from numbersprotocol/milestone-v231017

┆Issue is synchronized with this Asana task by Unito ┆Created By: Sam

sync-by-unito[bot] commented 11 months ago

➤ Sam commented:

Will try ChatGPT's suggestion.

To resolve this issue, you should do the following:

  1. Update Google Play Billing Library: Make sure you are using the latest version of the Google Play Billing Library in your Android app. You can check the latest version on the official Android Developers website or in your app's build.gradle file. Update the library version in your app's dependencies and rebuild your app.

For example, in your app's build.gradle file, you might have something like this:


dependencies {

implementation 'com.android.billingclient:billing:4.0.0' // Use the latest version

// Other dependencies...

}

Ensure that you are using the latest version by replacing 4.0.0 with the latest version number.

  1. Test Your App: After updating the Google Play Billing Library, thoroughly test your app to make sure that all billing-related functionality works as expected. This includes testing in-app purchases, subscriptions, and any other billing-related features.

  2. Review Google Play Console: Log in to your Google Play Developer Console and review the release that you are trying to upload. Make sure that all the billing configurations and settings are up to date and correctly configured.

  3. Check Your GitHub Action Workflow: Ensure that your GitHub Actions workflow is configured correctly to build and upload your Android app. Verify that the build process is using the updated Google Play Billing Library.

  4. Retry the Upload: Once you've updated your app's billing library and verified that everything is working correctly, attempt to upload your release to Google Play again.

If you continue to encounter issues after following these steps, consider checking the release notes and documentation for the r0adkll/upload-google-play GitHub Action you're using, as there might be specific requirements or updates needed for this action. Additionally, make sure that you have the necessary permissions and credentials to upload releases to Google Play within your GitHub Action workflow.

sync-by-unito[bot] commented 11 months ago

➤ Sam commented:

ChatGPT suggestion will not work. Because com.android.billingclient:billing:4.0.0 is configured in capacitor.build.gradle ( https://github.com/numbersprotocol/capture-lite/blob/d0edc614e1cec7ac976ff10461eb25a5145bcfb0/android/app/capacitor.build.gradle#L36 ).

However capacitor.build.gradle ( https://github.com/numbersprotocol/capture-lite/blob/d0edc614e1cec7ac976ff10461eb25a5145bcfb0/android/app/capacitor.build.gradle#L36 ) is regenerated each time when capacitor update is run which will override back to 4.0.0

sync-by-unito[bot] commented 11 months ago

➤ Sam commented:

As mentioned before here ( https://app.asana.com/0/0/1206062916657895/1206086153582561/f )

Side note: once WIP: bump android billing client to 5.2.1 ( https://github.com/numbersprotocol/capture-lite/commit/ecacfdbf9abef8add5c80f1b5ccaae5582f308e8 ) will be merged to master it should also fix [Issue] fix deploy-play-store GitHub CI ( https://app.asana.com/0/1201016280880500/1206062906361649 ) ...

We a can see that [Issue] fix deploy-play-store GitHub CI ( https://app.asana.com/0/0/1206062906361649 ) is fixed as seen GitHub action runs ( https://github.com/numbersprotocol/capture-lite/actions/runs/7085354487 ).

Can be considered as fixed.