search

numbersprotocol / capture-lite

A photo-sharing app with only verifiable photos and videos.
https://numbersprotocol.github.io/
GNU General Public License v3.0
25 stars 6 forks source link

v240206-capture-cam-ionic #3196

Closed sync-by-unito[bot] closed 7 months ago

sync-by-unito[bot] commented 8 months ago

﹍Product code:﹍

﹍Release milestone:﹍

﹍Testing level:﹍

﹍Release note:﹍

﹍Expectation:﹍

﹍Known Issue:﹍

﹍Limitation:﹍

﹍Test Link﹍:

﹍Note:﹍

﹍Testing Results (add this after QA test)﹍:

﹍Testing Plan (add this after QA test):﹍

Testing Levels:

┆Issue is synchronized with this Asana task by Unito ┆Created By: Sam

sync-by-unito[bot] commented 8 months ago

➤ Sherry Chung commented:

Sam (cc Scott YanKenny Hung) Will item 3c (see screenshot, what we discussed in Sprint 24.01.29 kickoff ( https://app.asana.com/0/0/1206458446271108 ) ) be also taken care in this release?

Screenshot 2024-02-05 at 12.12.34.png
sync-by-unito[bot] commented 8 months ago

➤ Sam commented:

Sherry Chung, sure, however I couldn't find any relevant asana card for [issue] Fix email issues?

I believe [issue] Fix email issues can delivered in 2nd milestone (v240213-capture-cam-ionic) of Sprint 24.01.29.

Let me know what you think.

sync-by-unito[bot] commented 8 months ago

➤ Kenny Hung commented:

Sam

Please create one for it. could refer it, because as I know the mint & share process is similar. (rely on CaptureClub)

sync-by-unito[bot] commented 8 months ago

➤ Kenny Hung commented:

As I know, this sprint will close this week, so if you need 2nd milstone, it means this task will be pushed into next sprint.

sync-by-unito[bot] commented 8 months ago

➤ Sherry Chung commented:

Sam The original issue that user reported is Receive two different emails after minting NFT via Dashboard ( https://app.asana.com/0/0/1206415038646327 ).

However, the detail tasks that the dev side need to do to complete solve the problem will rely on each dev member to open by themselves according to tasks breakdown.

I've take some notes in Sprint 24.01.29 kickoff ( https://app.asana.com/0/0/1206458446271108 ) that might help you to solve this issues. Please discuss with other dev team member if you need help.

sync-by-unito[bot] commented 8 months ago

➤ Sam commented:

Sherry Chung (Kenny Hung, Scott Yan) regarding Will item 3c (see screenshot, what we discussed in Sprint 24.01.29 kickoff ) be also taken care in this release ( https://app.asana.com/0/0/1206491967244628/1206518360572018/f ).

I recommend postpone 3c to next release since it will need changes in ionic + iframe side ( https://app.asana.com/0/0/1206518981379737/1206532089649893/f ).

sync-by-unito[bot] commented 8 months ago

➤ Sherry Chung commented:

Sam Please check my latest comment in Comment by @Sherry Chung on [issue] Fix email issues ( https://app.asana.com/0/0/1206518981379737/1206532136389667/f )

For ionic side, if the issue exist, do you think it can be fixed in current release as well? (Just checking)

sync-by-unito[bot] commented 8 months ago

➤ Sam commented:

Sherry Chung, current release due date is Feb 6. To avoid delays ( https://docs.google.com/presentation/d/1Geqva4rhqUQfihGXKfwn3m4iBYF0bWAvwnONBUgiidk/edit#slide=id.g266f5f45748_0_5 ) I would like to deliver v240206-capture-cam-ionic-internal ( https://app.asana.com/0/0/1206491967244628 ) with it's current dependencies today.

Regarding:

For ionic side, if the issue exist, do you think it can be fixed in current release as well? (Just checking)

I'm still waiting for clarification ( https://app.asana.com/0/0/1206518981379737/1206532089649893/f ) so I don't think it can be added todays release

sync-by-unito[bot] commented 8 months ago

➤ Sherry Chung commented:

Sam OK.

Suggestion - Please initial the discussion for what is mentioned in kick-off next time. Instead of wait until sprint manager asked about the progress.

sync-by-unito[bot] commented 8 months ago

➤ Sam commented:

Kenny Hung (cc: Sherry Chung), I noticed that [issue] Reliable Asset Restoration for Accounts with High Asset Volumes ( https://app.asana.com/0/0/1206346473214790 ) is happening only when I add fix for [FR] sort assets in VERIFIED tab by uploaded_at ( https://app.asana.com/0/0/1206137436792277 ).

If I do not add fix for [FR] sort assets in VERIFIED tab by uploaded_at ( https://app.asana.com/0/0/1206137436792277 ) this [issue] Reliable Asset Restoration for Accounts with High Asset Volumes ( https://app.asana.com/0/0/1206346473214790 ) is not happening.

Can we release v240206-capture-cam-ionic-internal ( https://app.asana.com/0/1201016280880500/1206491967244628/f ) with the following

I need more time to find out why changes from [FR] sort assets in VERIFIED tab by uploaded_at ( https://app.asana.com/0/1206344750031575/1206137436792277 ) are causing [issue] Reliable Asset Restoration for Accounts with High Asset Volumes ( https://app.asana.com/0/1206344750031575/1206346473214790 )

sync-by-unito[bot] commented 8 months ago

➤ Sherry Chung commented:

Sam I think we revert everything that previous implemented in ✓ v231207-capture-cam-ionic ( https://app.asana.com/0/0/1206102041960804 ) .

It contained 3 implementation in above release. So we just pretended none of them were complete. You can pick whatever you feel confidence among them to release this time.

As long as the issue/FR is finished and won't cause any new issues.

sync-by-unito[bot] commented 8 months ago

➤ Sam commented:

Kenny Hung I'm preparing firebase release now v240206-capture-cam-ionic-internal ( https://app.asana.com/0/1206344750031575/1206491967244628 ) with the following changes

Will be downloadable from firebase in 15 minutes.

sync-by-unito[bot] commented 8 months ago

➤ Sam commented:

Kenny Hung (cc: Sherry Chung)

Release reminder submitted ( https://airtable.com/app4oLOHhBT06Hivf/tblcLcxnayIP3LXji/receq4N2PNAKRqHs4 )

v240206-capture-cam-ionic-internal ( https://app.asana.com/0/1206344750031575/1206491967244628 )-(0.88.9)(firebase-release):

sync-by-unito[bot] commented 8 months ago

➤ Kenny Hung commented:

Sam

Just confirm

[FR] sort assets in VERIFIED tab by uploaded_at ( https://app.asana.com/0/1201016280880500/1206137436792277/f ) doesn't include in this milestone, am I right?

sync-by-unito[bot] commented 8 months ago

➤ Kenny Hung commented:

Sam (cc Tammy YangJames Chien)

There are two questions

  1. There is user behavior changed as below, although everything looks normal during the testing process, I'm not sure why it was designed this way initially. It might be necessary to ask James Chien this part.

    1. In previous version(0.88.8), when user has assets are in uploading, the pull down to refresh will be blocked
    2. In this version, user pull down to display restore pop-up, it won't be blocked.

  2. I checked the asset from this version, the service_name is also "dev", does it expect? (If not, I suggest we could fix it later, because live version has the same issue.)

sync-by-unito[bot] commented 8 months ago

➤ Sam commented:

Kenny Hung we should keep original behavior so it should not let user refresh/restore during uploads. unless QA wants to let user know that during upload refresh/restore are not allowed

yes because issue with dev keys were detected after fire base release

sync-by-unito[bot] commented 8 months ago

➤ Kenny Hung commented:

Sam Could we have a quickly huddle?

sync-by-unito[bot] commented 8 months ago

➤ Kenny Hung commented:

Sam (cc James ChienTammy Yang)

Huddle summary

  1. Please keep the same behavior (when user has assets are in uploading, the pull down to refresh will be blocked) → re-release new version.
  2. For dev key (environment variable issue), please create an asana card, QA suggest fixing it next milestone.
sync-by-unito[bot] commented 8 months ago

➤ Sam commented:

Kenny Hung

  1. Will do it now and re-release in 20 minutes.
  2. Done ( https://dt42-numbers.slack.com/archives/CS29L7Z5H/p1707366114196419?thread_ts=1707215456.155179&cid=CS29L7Z5H ).
sync-by-unito[bot] commented 8 months ago

➤ Sam commented:

Kenny Hung

Release reminder submitted ( https://airtable.com/app4oLOHhBT06Hivf/tblcLcxnayIP3LXji/recff3cBGSMuU7jab )

v240206-capture-cam-ionic-internal ( https://app.asana.com/0/1206344750031575/1206491967244628 )-(0.89.0)(firebase-release):

sync-by-unito[bot] commented 8 months ago

➤ Kenny Hung commented:

Sam (cc Tammy YangScott Yan)

v240206 issue fixed, next please add this task.

[FR] Disable upload feature on Capture Cam ( https://app.asana.com/0/1201083422707776/1206531773468998/f ).

It's because QA found [issue] Image from Capture Cam upload will change. ( https://app.asana.com/0/0/1206518277335341 ) We want to avoid this issue & lead some user to dashboard.

sync-by-unito[bot] commented 8 months ago

➤ Sam commented:

Kenny Hung (cc: Sherry Chung)

Release reminder submitted ( https://airtable.com/app4oLOHhBT06Hivf/shrJc1CR3LdYwD8zc/tblcLcxnayIP3LXji/viwkmgJXkJbyMiIGT/recQNE1kuO2igCNRf ).

Same build that passed QA test ( https://app.asana.com/0/0/1206491967244628/1206551064456073/f ) but with right API keys.

v240206-capture-cam-ionic-internal ( https://app.asana.com/0/1206344750031575/1206491967244628 )-(0.89.1)(firebase-release):

James Chien

sync-by-unito[bot] commented 8 months ago

➤ Kenny Hung commented:

Sam (cc James Chien) Just double confirm,

Is 0.89.1 code review done?

sync-by-unito[bot] commented 8 months ago

➤ Sam commented:

Yes it was reviewed before