numbersprotocol / community-support

This is a channel for Numbers community to report issues or open feature requests.
224 stars 4 forks source link

Definition of assetTimestampCreated is not clear #315

Closed sync-by-unito[bot] closed 1 year ago

sync-by-unito[bot] commented 1 year ago

Your email:

tammy@numbersprotocol.io

Is this a general issue/FR report or a ticket that involve your personal account?:

No personal information involved

Select product:

Other

One line to describe the issue you see or the feature you want to add:

Definition of assetTimestampCreated is not clear

Let us know what do you expect to see?:

Look at this asset (https://nftsearch.site/asset-profile?nid=bafybeicfddmorpjewdxhuwnxgkr2uhb6ksk3xsumdjh3l57gzhudbkypji), the Creation Time shows 4th July 2023. Asset Profile grab the information from the assetTimestampCreated field in the AssetTree. However, if you open the integrity file, you will notice that the time in there is different (1543654800).

I checked our spec (https://docs.numbersprotocol.io/introduction/numbers-protocol/defining-web3-assets/assettree), assetTimestampCreated is: Creation time of the asset file.

Which one makes more sense?

A. assetTimestampCreated is the time when the digital media file becomes an Web3 asset

B. assetTimestampCreated is the time when the digital media file was created

Please provide some simple steps to help us reproduce the issue or understand how do you want to see the feature.:

  1. Open https://nftsearch.site/asset-profile?nid=bafybeicfddmorpjewdxhuwnxgkr2uhb6ksk3xsumdjh3l57gzhudbkypji

  2. Open the first AssetTree then open its integrity file (copy integrityCid and read it through IPFS gateway

What's the device or browser do you use?:

Edge

———————————————

This task was submitted through Issue Report/Feature Request

https://form.asana.com/?k=OlNjzNIasZt0uOT5gzb7pw&d=1200886955782960

┆Issue is synchronized with this Asana task by Unito

tammyyang commented 1 year ago

According to C2PA definition of the asset, I believe it should be A: assetTimestampCreated is the time when the digital media file becomes an Web3 asset

tammyyang commented 1 year ago

@olgahaha I think we can close this ticket, however, just want to also confirm we are clear about "NFTs imported". In that case, the assetTimestampCreated should be the time when NFT is created, right? (because it was already a Web3 asset at that time)

olgahaha commented 1 year ago

Yes, you're correct. In order to address this case, it would be necessary to update the backend code to handle it appropriately.

tammyyang commented 1 year ago

Great 👍 I will leave it to you to open the ticket for the backend dev. Gitbook has been updated https://docs.numbersprotocol.io/introduction/numbers-protocol/defining-web3-assets/assettree and I believe this ticket can be closed