Closed sync-by-unito[bot] closed 1 year ago
➤ Olga commented:
Tammy Yang Could you please provide a brief description of the task? I'm not sure I fully understand what it entails.
➤ Tammy Yang commented:
Olga added to the description, thank you for the reminder.
➤ Olga commented:
Bofu Chen The name and document of the license have been updated in the storage backend. As a next step, I'm planning to replace the code ( https://github.com/numbersprotocol/nit/blob/main/src/license.ts#LL3C1-L3C1 ) of the nit module with the SPDX license. This will help ensure consistency and compliance across the codebase.
➤ Bofu Chen commented:
Olga yes, you can set me as the reviewer after the pull request is ready
➤ Olga commented:
Bofu Chen please help review PR 24 for the nit https://github.com/numbersprotocol/nit/pull/26 ( https://github.com/numbersprotocol/nit/pull/26 )
➤ Bofu Chen commented:
Olga I've accepted this pull request and added some changes.
You can check my changes here: https://github.com/numbersprotocol/nit/pull/26/commits ( https://github.com/numbersprotocol/nit/pull/26/commits )
Current nit always show default license, this is not expected in most cases. nit should not have any default values unless written in Gitbook.
┆Issue is synchronized with this Asana task by Unito ┆Created By: Tammy Yang