numbersprotocol / nit

Git of Web3 assets
https://docs.numbersprotocol.io/
MIT License
4.45k stars 8 forks source link

Do not show default license #23

Closed sync-by-unito[bot] closed 1 year ago

sync-by-unito[bot] commented 1 year ago

Current nit always show default license, this is not expected in most cases. nit should not have any default values unless written in Gitbook.

┆Issue is synchronized with this Asana task by Unito ┆Created By: Tammy Yang

sync-by-unito[bot] commented 1 year ago

➤ Olga commented:

Tammy Yang Could you please provide a brief description of the task? I'm not sure I fully understand what it entails.

sync-by-unito[bot] commented 1 year ago

➤ Tammy Yang commented:

Olga added to the description, thank you for the reminder.

sync-by-unito[bot] commented 1 year ago

➤ Olga commented:

Bofu Chen The name and document of the license have been updated in the storage backend. As a next step, I'm planning to replace the code ( https://github.com/numbersprotocol/nit/blob/main/src/license.ts#LL3C1-L3C1 ) of the nit module with the SPDX license. This will help ensure consistency and compliance across the codebase.

sync-by-unito[bot] commented 1 year ago

➤ Bofu Chen commented:

Olga yes, you can set me as the reviewer after the pull request is ready

sync-by-unito[bot] commented 1 year ago

➤ Olga commented:

Bofu Chen please help review PR 24 for the nit https://github.com/numbersprotocol/nit/pull/26 ( https://github.com/numbersprotocol/nit/pull/26 )

sync-by-unito[bot] commented 1 year ago

➤ Bofu Chen commented:

Olga I've accepted this pull request and added some changes.

You can check my changes here: https://github.com/numbersprotocol/nit/pull/26/commits ( https://github.com/numbersprotocol/nit/pull/26/commits )