numenta / htm.java

Hierarchical Temporal Memory implementation in Java - an official Community-Driven Java port of the Numenta Platform for Intelligent Computing (NuPIC).
GNU Affero General Public License v3.0
310 stars 160 forks source link

Fixed documentation typo in CLA Classifier #504

Closed JonnoFTW closed 7 years ago

JonnoFTW commented 7 years ago

Fixes #505

I fixed a typo about the return type and the example in the comment using mixed decimal point styles.

cogmission commented 7 years ago

@JonnoFTW Thanks dude!

  1. You need to sign the CL (contributor's license) and then Matt will "approve" it and that first error will go away ;-)
  2. You need to open up an "issue" and then in the comment above within this PR, you should put ```Fixes #" --> take a look at this as an example (where it says "Fixes") at the top.
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 83.077% when pulling 6fcf5444cdca3fd545d0f2c720afb12f0d040d55 on JonnoFTW:master into fce18372e25929a58fb19a01afd11d0e461776a5 on numenta:master.

cogmission commented 7 years ago

@rhyolight Please review @JonnoFTW 's CL

cogmission commented 7 years ago

@JonnoFTW Have you signed the Contributor's License yet?

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 83.077% when pulling 6fcf5444cdca3fd545d0f2c720afb12f0d040d55 on JonnoFTW:master into fce18372e25929a58fb19a01afd11d0e461776a5 on numenta:master.

JonnoFTW commented 7 years ago

@cogmission yes I have. I got confirmation that it was received this morning.

rhyolight commented 7 years ago

@JonnoFTW @cogmission It's all good. There is something wrong with the validator. Good to merge. 👍

cogmission commented 7 years ago

@rhyolight Thanks buddy!