search

numenta / htm.java

Hierarchical Temporal Memory implementation in Java - an official Community-Driven Java port of the Numenta Platform for Intelligent Computing (NuPIC).
GNU Affero General Public License v3.0
308 stars 160 forks source link

Changed use of "==" operator to Class.isAssignableFrom method #514

Closed Hopding closed 7 years ago

Hopding commented 7 years ago

Fixes #513. This PR changes use of == operator to Class.isAssignableFrom method in Layer.java.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.009%) to 83.114% when pulling 77889c9eb9fb989bd5d400b3e089996815180c1b on Hopding:robust-classifier-type-comparison-513 into bec5f6ffc3d5ad5ce793fca0e58b930f0b5fe0c3 on numenta:master.

cogmission commented 7 years ago

@Hopding Hi, what I usually do at this point is follow the coveralls link and review the classes there that can use some "coverage", and create new tests until coveralls is happy. Something we all go through I'm afraid because coveralls isn't perfect?

Hopding commented 7 years ago

@cogmission Ah, I'm afraid I hadn't realized the Coveralls check failed. Thanks for bringing that to my attention. I'll take a look and fix it as soon as I get a chance.

Hopding commented 7 years ago

Haven't forgotten about this. Been busy, but should have some time for this soon :+1:

cogmission commented 7 years ago

No worries. I have lot's going on personally too, so I can relate...

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 83.208% when pulling ed46d0e71f83df2f5a26e17c8696708ccb9aca44 on Hopding:robust-classifier-type-comparison-513 into bec5f6ffc3d5ad5ce793fca0e58b930f0b5fe0c3 on numenta:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.09%) to 83.211% when pulling ed46d0e71f83df2f5a26e17c8696708ccb9aca44 on Hopding:robust-classifier-type-comparison-513 into bec5f6ffc3d5ad5ce793fca0e58b930f0b5fe0c3 on numenta:master.

Hopding commented 7 years ago

@cogmission There, should be all better now :+1: My apologies for the delay.

cogmission commented 7 years ago

@Hopding No need to apologize, I knew you'd get around to it. Nice Tests!