numenta / htm.java

Hierarchical Temporal Memory implementation in Java - an official Community-Driven Java port of the Numenta Platform for Intelligent Computing (NuPIC).
GNU Affero General Public License v3.0
308 stars 160 forks source link

Performance optimization of multidimensional array access #535

Open jan-zajic opened 6 years ago

jan-zajic commented 6 years ago

Based on discussion in thread https://discourse.numenta.org/t/performance-optimization-of-htm-java/2652 i made optimization of get/set value/slice methods in htm.java.

jan-zajic commented 6 years ago

@ibobak @cogmission can you have a look at this?

jan-zajic commented 6 years ago

@cogmission i had signed Contributor License with my username but validation failed, is validar check something else than username?

cogmission commented 6 years ago

Hi @jan-zajic,

We have to wait for @rhyolight (Matt Taylor) to approve your License form.

@rhyolight can you have a look when you get a chance?

rhyolight commented 6 years ago

Sorry I missed this. Will do next business day.

rhyolight commented 6 years ago

I think this is ok to merge now.

cogmission commented 6 years ago

Hi @jan-zajic,

I apologize for the delay in getting back to this PR, are you still around? Let me know because I have some changes I would like to make before this PR is merged.

Cheers, David

jan-zajic commented 6 years ago

Hi @cogmission, i was a little busy but i'am back, what changes do you mean?

jan-zajic commented 5 years ago

@cogmission, are you still around? I am. Or is htm.java dead (Latest commit on 14 Sep 2017)?

cogmission commented 5 years ago

@jan-zajic I'm still here... Been real busy w/my day job which also used to allot time for HTM.Java development (since they are also sponsors), but my role has expanded and left less time for HTM.Java recently. I will be getting back very soon though because I have projects that require it.