DeltaEncoder should encode the delta not the input

numenta / htm.java

Hierarchical Temporal Memory implementation in Java - an official Community-Driven Java port of the Numenta Platform for Intelligent Computing (NuPIC).

GNU Affero General Public License v3.0

308 stars 160 forks source link

DeltaEncoder should encode the delta not the input #545

Open roiebe opened 5 years ago

roiebe commented 5 years ago

org.numenta.nupic.encoders.DeltaEncoder.java line 113:

super.encodeIntoArray(input, output);

should be:

super.encodeIntoArray(delta, output);

see python version: nupic/encoders/delta.py line 79:

self._adaptiveScalarEnc.encodeIntoArray(delta, output, learn)