Closed scottpurdy closed 5 years ago
@scottpurdy I know this is a WIP, but do you know there is a missing import for capacity_simulation
? At least I cannot run the scripts in this PR as-is.
@rhyolight - I haven't done any validation yet. Feel free to share anything specific you've found but I will validate before merge
Specifically, looks like capacity_simulation
is missing:
∙ python run_capacity_heatmap.py --bumpType gaussian --resultName results/capacityHeatmap_gaussian.json --repeat 1
Traceback (most recent call last):
File "run_capacity_heatmap.py", line 24, in <module>
import capacity_simulation
ImportError: No module named capacity_simulation
@lscheinkman - This work is now blocked on htmresearch==0.0.3 release (which requires htmresearch-core release).
Two of these files aren't needed:
In htmresearch/projects/union_path_integration
I meant to move these to the "entorhinal" subfolder. (I forgot.)
In all of the files that contain --repeat 1
, we can just change it to --repeat 5
.
@scottpurdy Done with my review. 👍 I was able to reproduce all charts with the changes above.
This should be ready to merge now aside from needing a link in the top level README to the journal web page for the paper once it is published.
WIP