numenta / nupic-legacy

Numenta Platform for Intelligent Computing is an implementation of Hierarchical Temporal Memory (HTM), a theory of intelligence based strictly on the neuroscience of the neocortex.
http://numenta.org/
GNU Affero General Public License v3.0
6.33k stars 1.56k forks source link

Refactor Anomaly Tests to use General DataGenerators #1871

Open cogmission opened 9 years ago

cogmission commented 9 years ago

Regarding these two methods:

https://github.com/numenta/nupic/blob/master/tests/unit/nupic/algorithms/anomaly_likelihood_test.py#L35

https://github.com/numenta/nupic/blob/master/tests/unit/nupic/algorithms/anomaly_likelihood_test.py#L64

This code should be extracted to a generic generator and the above test should be refactored to use the general data generator classes in "nupic.data.generators"

scottpurdy commented 9 years ago

@cogmission - hopefully we don't have to create a new data generator and one of the existing ones will work

cogmission commented 9 years ago

@scottpurdy Yep. As long as it's clear by the name what kind of data the class generates?