search

numenta / nupic-legacy

Numenta Platform for Intelligent Computing is an implementation of Hierarchical Temporal Memory (HTM), a theory of intelligence based strictly on the neuroscience of the neocortex.
http://numenta.org/
GNU Affero General Public License v3.0
6.34k stars 1.56k forks source link

Added conditions for IO for coord encoder #3762

Closed rhyolight closed 7 years ago

rhyolight commented 7 years ago

Fixes #3761

This is bad code practice, but I don't have time to make a clean fix. The right answer is to simply provide an implementation of getBucketIndices for the CoordinateEncoder, but I honestly don't know how to do it. This is a quick fix.

numenta-ci commented 7 years ago

@rhyolight, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ywcui1990, @scottpurdy and @oxtopus to be potential reviewers.

rhyolight commented 7 years ago

Goal is to make it easier for users to construct models. At least one user wants to have more encoder options in the OPF. The OPF is already full of special cases like this, and we're not planning on fixing them. So I don't see the harm of adding CoordinateEncoder support. It was not hard to do, and I'll make it clear in our forums that this new functionality of the OPF does not include prediction.

rhyolight commented 7 years ago

Ok, @scottpurdy just figured out what was wrong in the original report, and we don't actually have to do this.