Fixed BacktrackingTM serialization error

numenta / nupic-legacy

Numenta Platform for Intelligent Computing is an implementation of Hierarchical Temporal Memory (HTM), a theory of intelligence based strictly on the neuroscience of the neocortex.

http://numenta.org/

GNU Affero General Public License v3.0

6.33k stars 1.56k forks source link

Fixed BacktrackingTM serialization error #3765

Closed rhyolight closed 6 years ago

rhyolight commented 6 years ago

Fixes #3763

numenta-ci commented 6 years ago

@rhyolight, thanks for your PR! By analyzing the history of the files in this pull request, we identified @scottpurdy, @marionleborgne and @subutai to be potential reviewers.

rhyolight commented 6 years ago

@lscheinkman

lscheinkman commented 6 years ago

@rhyolight This class serialization is currently not covered by our tests (see https://ci.numenta.com/browse/NUP-PY-561/artifact/TL/HTML-Coverage-Report/_root_bamboo-agent-home_xml-data_build-dir_NUP-PY-TL_src_nupic_algorithms_backtracking_tm.html#n1372). That's why it remained unnoticed. Maybe we could also add a test covering this issue, either in this PR or in a separate PR.

rhyolight commented 6 years ago

@lscheinkman I'd be more than happy if someone did this, but honestly increasing test coverage on this code base is not a high priority. If anyone reading this wants to create an issue and a test to cover this bug, please do.