search

numenta / nupic-legacy

Numenta Platform for Intelligent Computing is an implementation of Hierarchical Temporal Memory (HTM), a theory of intelligence based strictly on the neuroscience of the neocortex.
http://numenta.org/
GNU Affero General Public License v3.0
6.33k stars 1.56k forks source link

Added holidays parameter to date encoder #3822

Closed JonnoFTW closed 6 years ago

JonnoFTW commented 6 years ago

Fixes #3821

Also fixed up some typos.

rhyolight commented 6 years ago

@JonnoFTW Please investigate test failures in CI.

lscheinkman commented 6 years ago

@JonnoFTW Could separate the holiday feature from the other changes related to swarming?

JonnoFTW commented 6 years ago

@lscheinkman my bad, I forgot to merge with upstream. It should be good now. Do you know how I can get it to stop listing those really old commits in every pull request?

lscheinkman commented 6 years ago

@JonnoFTW You can try using git rebase --interactive and squash the old commits

rhyolight commented 6 years ago

I can squash and merge from the UI.

rhyolight commented 6 years ago

Nice @JonnoFTW thanks!