search

numenta / nupic-legacy

Numenta Platform for Intelligent Computing is an implementation of Hierarchical Temporal Memory (HTM), a theory of intelligence based strictly on the neuroscience of the neocortex.
http://numenta.org/
GNU Affero General Public License v3.0
6.34k stars 1.56k forks source link

VectorFileSensor correct usage of NTA_CHECK? #3825

Closed sjgallagher2 closed 6 years ago

sjgallagher2 commented 6 years ago

Noticed that in the VectorFileSensor.cpp function setParameterFromBuffer:328 it seems the NTA_CHECK assertion is backwards in some places. For example: void VectorFileSensor::setParameterFromBuffer(const std::string& name, Int64 index, IReadBuffer& value) ... if (name == "repeatCount") { NTA_CHECK(value.read(int_param) == 0) << where << "Unable to read repeatCount: " << int_param << " - Should be a positive integer"; It appears that this checks if the supplied value is 0, and otherwise it throws a 'positive integer' error. Shouldn't this be: NTA_CHECK(value.read(int_param) > 0) << where << "Unable to read repeatCount: " << int_param << " - Should be a positive integer";? Or maybe I'm confused about how to use NTA_CHECK or value.read().

sjgallagher2 commented 6 years ago

Meant to post this to nupic.core, closing issue and moving it.