Off by one bug in _filterLikelihoods redThreshold vs yellowThreshold

numenta / nupic-legacy

Numenta Platform for Intelligent Computing is an implementation of Hierarchical Temporal Memory (HTM), a theory of intelligence based strictly on the neuroscience of the neocortex.

http://numenta.org/

GNU Affero General Public License v3.0

6.33k stars 1.56k forks source link

Off by one bug in _filterLikelihoods redThreshold vs yellowThreshold #3870

Open ghost opened 5 years ago

rhyolight commented 5 years ago

@kyle-sorensen Your change has cause a couple tests to fail. If there is an off by one bug, then these tests must be incorrectly defined. Can you read them to confirm that?

AnomalyLikelihoodAlgorithmTest.testFilterLikelihodsInputType
AnomalyLikelihoodAlgorithmTest.testFilterLikelihoods

breznak commented 5 years ago

Subscribing, @kyle-sorensen if you fix this, could you please make a PR also to https://github.com/htm-community/nupic.cpp/issues/469 ? Would be appreciated!