Open sjgallagher2 opened 6 years ago
@scottpurdy or @lscheinkman do you guys know how NTA_CHECK
works?
The expression inside NTA_CHECK()
should evaluate to true when the code and inputs are correct. I'm not sure if the listed check is incorrect though. The comment says that int_param
should be a positive integer, not the return value of read
.
Noticed that in the VectorFileSensor.cpp function setParameterFromBuffer:328 it seems the NTA_CHECK assertion is backwards in some places. For example:
It appears that this checks if the supplied value is 0, and otherwise it throws a 'positive integer' error. Shouldn't this be:
Or maybe I'm confused about how to use NTA_CHECK or value.read().