numere-org / NumeRe

Framework for numerical computations, data analysis and visualisation
https://www.numere.org
GNU General Public License v3.0
18 stars 6 forks source link

32-function-for-accessing-the-users-current-language #100

Closed MarkRamp closed 1 year ago

MarkRamp commented 1 year ago

SUMMARY

Implements necessary changes for #32

Reviewers: @numere-org/maintainers

IMPLEMENTATION

DOCUMENTATION


TESTS BY REVIEWERS

numeredev commented 1 year ago

Needs the addition of getuilang() at the other locations in code (about two).

MarkRamp commented 1 year ago

A side question, I was trying to test this, but it threw error that getuilang function does not exist. Is it also becuase I used _guilang and not _lang?

numeredev commented 1 year ago

A side question, I was trying to test this, but it threw error that getuilang function does not exist. Is it also becuase I used _guilang and not _lang?

Nope, I think that's because the parser does not yet know, how to find the function. For testing, try to enter getuilang() + "". For production, you've to search for occurences of getversioninfo( in code and add getuilang( to those conditions.

numeredev commented 1 year ago

Changes accepted. Will be merged after tests have been implemented.

@durveshps You're missing the entry in the ChangesLog. Please add that.

MarkRamp commented 1 year ago

@numeredev I updated changes.tmp, I hope that is what you meant.