Closing print preview of documentation browser results in a crash - Githubissues

numere-org / NumeRe

Framework for numerical computations, data analysis and visualisation

https://www.numere.org

GNU General Public License v3.0

20 stars 7 forks source link

Closing print preview of documentation browser results in a crash #119

Closed numeredev closed 1 year ago

numeredev commented 1 year ago

SUMMARY

Implements necessary changes for #116

Reviewers: @numere-org/maintainers

IMPLEMENTATION

Implementation: Fixed the problem by introducing a secondary wxHtmlPrintout object.
Implementation test: Some print previews of documentation browsers were created and closed without problems.

DOCUMENTATION

[x] ChangesLog updated
[x] Code changes commented
Documentation articles:
- [ ] corresponding documentation articles updated
- [ ] new documentation articles created
- [x] not needed
Language files:
- [ ] corresponding language files updated
- [x] not needed

TESTS BY REVIEWERS

[ ] Added to the automatic SW tests
[x] Tested manually

numeredev commented 1 year ago

Bug is probably only reproducable in x64 mode. A review of the changes might be sufficient.