Is your change request related to a problem? Please describe.
Some files, which are imported, are unnecessarily auto-converted although those files contain type information for their data.
Describe the solution you'd like
Disable the autoconversion for file types containing type information, i.e. NDAT, IBW, (JDX), XLS, (XLSX)
Describe possible alternatives you've considered
No alternative
Additional context
Add any other context or screenshots about the feature request here.
(Do not write below this line)
DEVS' SECTION
ANALYSIS
This is a quite easy change: In FileHeaderInfo FileAdapter::openFile(std::string _sFile, bool loadToCache, bool overrideTarget, int _nHeadline, const std::string& sTargetTable, std::string sFileFormat) at line 175 the statement _mem->convert(); has to be guarded by a function with determines, whether conversions are necessary. This function can be implemented within kernel/core/io/file.cpp to get the necessity to convert by the file type (get inspired by the getFileByType() function). It is expected that NDAT, IBW and XLS do not need the conversion. XLSX and JDX will need it.
DESCRIPTION
Is your change request related to a problem? Please describe. Some files, which are imported, are unnecessarily auto-converted although those files contain type information for their data.
Describe the solution you'd like Disable the autoconversion for file types containing type information, i.e. NDAT, IBW, (JDX), XLS, (XLSX)
Describe possible alternatives you've considered No alternative
Additional context Add any other context or screenshots about the feature request here.
(Do not write below this line)
DEVS' SECTION
ANALYSIS
This is a quite easy change: In
FileHeaderInfo FileAdapter::openFile(std::string _sFile, bool loadToCache, bool overrideTarget, int _nHeadline, const std::string& sTargetTable, std::string sFileFormat)at line 175 the statement_mem->convert();has to be guarded by a function with determines, whether conversions are necessary. This function can be implemented withinkernel/core/io/file.cppto get the necessity to convert by the file type (get inspired by thegetFileByType()function). It is expected thatNDAT,IBWandXLSdo not need the conversion.XLSXandJDXwill need it.IMPLEMENTATION STEPS
(see also our Wiki for implementation guidelines)
DOCUMENTATION STEPS
(see also our Wiki for further information)
*.NHLPand*.NDBfiles, if needed)*.NLNGfiles, if needed)PULL REQUEST