numere-org / NumeRe

Framework for numerical computations, data analysis and visualisation
https://www.numere.org
GNU General Public License v3.0
18 stars 6 forks source link

Make changes to Style numFmtId parser for excel #160

Closed semibroiled closed 9 months ago

semibroiled commented 9 months ago

SUMMARY

Implements necessary changes for #151

Reviewers: @numere-org/maintainers

IMPLEMENTATION

DOCUMENTATION


TESTS BY REVIEWERS

semibroiled commented 9 months ago

I'm unable to enter draft mode to do a commit. I want to make changes to changelog and add more characters to isDateTime... Function.

I haven't tested with SW_Test suite yet. I haven't broken anything else. But I couldn't pass or make sensible integration tests. I will follow up on this in the meeting. I suspect changes to changeExcelTimetoEpoch needs to be made