numere-org / NumeRe

Framework for numerical computations, data analysis and visualisation
https://www.numere.org
GNU General Public License v3.0
17 stars 5 forks source link

Regression: In animations, titles now only appear in the first animation frame #179

Closed numeredev closed 4 months ago

numeredev commented 4 months ago

DESCRIPTION

Describe the bug Plots containing a title and an animation now only show their respective title in their first frame. That might be a regression to a previous title-related change.

To Reproduce Steps to reproduce the behavior:

  1. Execute example script advanced_plotting.nscr
  2. Start one of the animations
  3. See error

Expected behavior The title is shown in all frames.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

(Do not write below this line)


DEVS' SECTION

ANALYSIS

The problem arose from the appearing duplicate titles in compositions. By adding a check for whether the code is currently preparing an animation, it should be solvable.

IMPLEMENTATION STEPS

(see also our Wiki for implementation guidelines)

DOCUMENTATION STEPS

(see also our Wiki for further information)

PULL REQUEST