numere-org / NumeRe

Framework for numerical computations, data analysis and visualisation
https://www.numere.org
GNU General Public License v3.0
18 stars 6 forks source link

Link the stop button in the main window with the cancel button in the debugger. #36

Closed raphael-sys closed 1 year ago

raphael-sys commented 1 year ago

DESCRIPTION

Is your change request related to a problem? Please describe. To me it is always a disruption when I try to stop my program and the stop button does not work because I am in a break point.

Describe the solution you'd like The functionality of the stop button in the main window and the cancel button in the debugger should be the same and be interchangeable while being in a break point or error.

Describe possible alternatives you've considered It would already be an improvement to make the stop button grey while the debugger is running. Then it would at least be visible why the button is not working. The other solution would be preferred, but this one would be an improvement as well.

Additional context

(Do not write below this line)


DEVS' SECTION

ANALYSIS

This can be implemented by factoring out the ID_DEBUG_CANCEL event ID from the menu event handler, so that it can be called from the outside. Furthermore, it is necessary to provide an interface to check, whether the debugger has the control. If this is true, then the handler for the ID_MENU_STOP_EXECUTION event ID in the main window shall redirect the call to the debugger to cancel the calculation.

IMPLEMENTATION STEPS

(see also our Wiki for implementation guidelines)

DOCUMENTATION STEPS

(see also our Wiki for further information)

PULL REQUEST

numeredev commented 1 year ago

What's to be clarified here?