numere-org / NumeRe

Framework for numerical computations, data analysis and visualisation
https://www.numere.org
GNU General Public License v3.0
18 stars 6 forks source link

Some table headlines in XLS files are not recognized any more #45

Closed numeredev closed 1 year ago

numeredev commented 1 year ago

DESCRIPTION

Describe the bug In some XLS files, the headlines are distributed among multiple rows. Those rows are not detected correctly any more.

To Reproduce Steps to reproduce the behavior:

  1. Load the attached file kante.xls
  2. OPen the table
  3. See misinterpreted headline

Expected behavior Headlines in such files should be loaded correctly again.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

(Do not write below this line)


DEVS' SECTION

ANALYSIS

In io/file.cpp in the member function void XLSSpreadSheet::readFile() is the number of headlines determined by whether the rows filled with strings is larger than zero. Change that, so that the number of headlines is determined by the string-only rows, if this number is smaller than 4 rows or 10% of the whole number of rows (whichever is larger).

IMPLEMENTATION STEPS

(see also our Wiki for implementation guidelines)

DOCUMENTATION STEPS

(see also our Wiki for further information)

PULL REQUEST